From: "Martin Storsjö" <martin@martin.st>
To: Jan Beulich <jbeulich@suse.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] ld: Add support for a new option, -exclude-symbols, in COFF object file directives
Date: Wed, 20 Jul 2022 18:10:31 +0300 (EEST) [thread overview]
Message-ID: <2937e25-994c-85b0-df33-c87d8e2a37@martin.st> (raw)
In-Reply-To: <b0e9a131-20ab-5c57-df7b-29c8720fe8b7@suse.com>
On Wed, 20 Jul 2022, Jan Beulich wrote:
> On 20.07.2022 14:39, Martin Storsjö wrote:
>> This directive isn't supposed to be used from a def file though (just like
>> the aligncomm directive), see the comment in deffile.h.
>
> Isn't supposed to be, or is prevented from being used that way? I have
> to admit that I'd find it quite helpful if this new option was also
> usable from a .def file. This might commonly be the more central place
> to record exclusions.
It's not possible to use it in a .def file with the current patch - it
would need to be recognized as a token at the very least. Do you want me
to try add support for that? I guess I could see a usecase for that too...
My intended usecase is to map __attribute__((visibility("hidden"))) and
similar (-fvisibility=hidden and -fvisibility-inlines-hidden) to this
embedded directive, in Clang/llvm. (Not sure how hard it would be to do
the same in GCC, but I have a Clang patch ready for that.)
// Martin
next prev parent reply other threads:[~2022-07-20 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 20:33 Martin Storsjo
2022-07-20 7:49 ` Jan Beulich
2022-07-20 12:39 ` Martin Storsjö
2022-07-20 13:43 ` Jan Beulich
2022-07-20 15:10 ` Martin Storsjö [this message]
2022-07-20 15:50 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2937e25-994c-85b0-df33-c87d8e2a37@martin.st \
--to=martin@martin.st \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).