From: Jan Beulich <jbeulich@suse.com>
To: Martin Storsjo <martin@martin.st>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] ld: Add support for a new option, -exclude-symbols, in COFF object file directives
Date: Wed, 20 Jul 2022 09:49:11 +0200 [thread overview]
Message-ID: <65b20943-0c1b-28f6-6f57-d3c4b8a9b75f@suse.com> (raw)
In-Reply-To: <20220719203330.1189542-1-martin@martin.st>
On 19.07.2022 22:33, Martin Storsjo wrote:
> @@ -946,6 +957,7 @@ diropts[] =
> { "-attr", SECTIONS },
> { "-export", EXPORTS },
> { "-aligncomm", ALIGNCOMM },
> + { "-exclude-symbols", EXCLUDE_SYMBOLS },
I was a little concerned by the - in the middle, but the (custom)
def-file lexer looks to be treating - the same as ISALPHA() chars.
Nevertheless it would be quite helpful if there were two testcases
here - one with the new directive used in an object file's .drectve
section and another with it used in a .def file.
The other thing is: According to def_exclude_symbols() each
directive is followed by exactly one symbol afaict. Hence
-exclude-symbol (singular) would seem more appropriate for the
option.
Jan
next prev parent reply other threads:[~2022-07-20 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 20:33 Martin Storsjo
2022-07-20 7:49 ` Jan Beulich [this message]
2022-07-20 12:39 ` Martin Storsjö
2022-07-20 13:43 ` Jan Beulich
2022-07-20 15:10 ` Martin Storsjö
2022-07-20 15:50 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65b20943-0c1b-28f6-6f57-d3c4b8a9b75f@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=martin@martin.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).