From: Mark Wielaard <mark@klomp.org>
To: binutils@sourceware.org
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
David Abdurachmanov <david.abdurachmanov@gmail.com>
Subject: Re: [PATCH] bfd: riscv_maybe_function_sym check _bfd_elf_is_local_label_name
Date: Fri, 12 Jan 2024 15:42:16 +0100 [thread overview]
Message-ID: <3a98cb9cba99328c8474db188c2ebce1a8f05664.camel@klomp.org> (raw)
In-Reply-To: <20240104003131.820681-2-mark@klomp.org>
On Thu, 2024-01-04 at 01:31 +0100, Mark Wielaard wrote:
> This fixes the ld "Handle no DWARF information" testcase. Which
> currently fails on riscv because a local label name is assumed
> to be the current function name.
>
> bfd/ChangeLog:
>
> * elfnn-riscv.c (riscv_maybe_function_sym): Also check
> _bfd_elf_is_local_label_name.
Ping. OK to push?
> ---
> bfd/elfnn-riscv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/bfd/elfnn-riscv.c b/bfd/elfnn-riscv.c
> index 509d61e5017..15c7fa3f89e 100644
> --- a/bfd/elfnn-riscv.c
> +++ b/bfd/elfnn-riscv.c
> @@ -5452,7 +5452,8 @@ riscv_maybe_function_sym (const asymbol *sym,
> bfd_vma *code_off)
> {
> if (sym->flags & BSF_LOCAL
> - && riscv_elf_is_mapping_symbols (sym->name))
> + && (riscv_elf_is_mapping_symbols (sym->name)
> + || _bfd_elf_is_local_label_name (sec->owner, sym->name)))
> return 0;
>
> return _bfd_elf_maybe_function_sym (sym, sec, code_off);
next prev parent reply other threads:[~2024-01-12 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 0:31 New riscv CI and try builder for binutils, some ld failures Mark Wielaard
2024-01-04 0:31 ` [PATCH] bfd: riscv_maybe_function_sym check _bfd_elf_is_local_label_name Mark Wielaard
2024-01-12 14:42 ` Mark Wielaard [this message]
2024-01-15 12:52 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a98cb9cba99328c8474db188c2ebce1a8f05664.camel@klomp.org \
--to=mark@klomp.org \
--cc=binutils@sourceware.org \
--cc=david.abdurachmanov@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).