public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Mark Wielaard <mark@klomp.org>, binutils@sourceware.org
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	David Abdurachmanov <david.abdurachmanov@gmail.com>
Subject: Re: [PATCH] bfd: riscv_maybe_function_sym check _bfd_elf_is_local_label_name
Date: Mon, 15 Jan 2024 12:52:02 +0000	[thread overview]
Message-ID: <408012df-897b-45a3-8450-43e0f219d109@redhat.com> (raw)
In-Reply-To: <3a98cb9cba99328c8474db188c2ebce1a8f05664.camel@klomp.org>

Hi Mark,

> On Thu, 2024-01-04 at 01:31 +0100, Mark Wielaard wrote:
>> This fixes the ld "Handle no DWARF information" testcase. Which
>> currently fails on riscv because a local label name is assumed
>> to be the current function name.
>>
>> bfd/ChangeLog:
>>
>> 	* elfnn-riscv.c (riscv_maybe_function_sym): Also check
>> 	_bfd_elf_is_local_label_name.
> 
> Ping. OK to push?

Approved - please apply.

Cheers
   Nick


      reply	other threads:[~2024-01-15 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04  0:31 New riscv CI and try builder for binutils, some ld failures Mark Wielaard
2024-01-04  0:31 ` [PATCH] bfd: riscv_maybe_function_sym check _bfd_elf_is_local_label_name Mark Wielaard
2024-01-12 14:42   ` Mark Wielaard
2024-01-15 12:52     ` Nick Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=408012df-897b-45a3-8450-43e0f219d109@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=david.abdurachmanov@gmail.com \
    --cc=mark@klomp.org \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).