public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: "Martin Liška" <mliska@suse.cz>, binutils@sourceware.org
Subject: Re: [PATCH] dwarf: use find_abstract_instance for vars and DW_AT_specification
Date: Mon, 8 Aug 2022 12:06:13 +0100	[thread overview]
Message-ID: <3d6dbb89-9084-1a79-dac8-eb11cebaba03@redhat.com> (raw)
In-Reply-To: <c0bb6496-00ba-b541-b588-72e2fd427772@suse.cz>

Hi Martin,

> bfd/ChangeLog:
> 
> 	PR 29442
> 	* dwarf2.c (struct varinfo): Use const char * type.
> 	(scan_unit_for_symbols): Call find_abstract_instance for
> 	DW_AT_specification for variables that can be in a different CU
> 	(e.g. done by dwz)

Approved - please apply.

I would ask for a testcase as well, but I am not sure if one could be
constructed that was independent of dwz.

Cheers
   Nick


      reply	other threads:[~2022-08-08 11:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-07 17:19 Martin Liška
2022-08-08 11:06 ` Nick Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d6dbb89-9084-1a79-dac8-eb11cebaba03@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).