From: Jan Beulich <jbeulich@suse.com>
To: Mark Harmstone <mark@harmstone.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] ld: Add pdb support to aarch64-w64-mingw32
Date: Tue, 24 Jan 2023 08:29:49 +0100 [thread overview]
Message-ID: <406a3491-8dc6-e027-092b-f8c4b5a0215b@suse.com> (raw)
In-Reply-To: <20230123230154.17957-1-mark@harmstone.com>
On 24.01.2023 00:01, Mark Harmstone wrote:
> This extends PDB support to the aarch64 PE targets.
>
> The changes to the test files are just to make it so they can be assembled as
> either x86, x86_64, or aarch64, mainly by changing the comment style.
> The only actual code change here is in adding the architecture constants
> to pdb.c.
Lgtm, so feel free to commit. One question though:
> --- a/ld/testsuite/ld-pe/pdb.exp
> +++ b/ld/testsuite/ld-pe/pdb.exp
> @@ -19,7 +19,8 @@
> # MA 02110-1301, USA.
>
> if {![istarget i*86-*-mingw*]
> - && ![istarget x86_64-*-mingw*]} {
> + && ![istarget x86_64-*-mingw*]
> + && ![istarget aarch64-*-mingw*]} {
> return
> }
Why only *-*-mingw* targets here? What about the others also permitting
PDB generation?
Jan
next prev parent reply other threads:[~2023-01-24 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 23:01 Mark Harmstone
2023-01-24 7:29 ` Jan Beulich [this message]
2023-01-25 0:10 ` Mark Harmstone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=406a3491-8dc6-e027-092b-f8c4b5a0215b@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=mark@harmstone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).