Re: [PATCH] Additional TC_EQUAL_IN_INSN check

[Nick Clifton <nickc@redhat.com>]

Hi Catherine,

> I don't think passing an extra argument is a big deal.  If s is available,
> why not use it instead of deducing it?

Well my point was: "why make an unnecessary change ?"

>  It turns out that the only port
> (other than the one I'm working on) which uses this macro is the hppa and
> the hppa port doesn't look at the string.  I've reworked the patch to pass s
> and not input_line_pointer to the TC_EQUAL_IN_INSN macro and also to use
> only one invocation of the macro as you suggested.  Okay to install, now?

Yes, with the proviso that you fix the documentation as Alan suggested.

> * read.c (read_a_source_file):  Check TC_EQUAL_IN_INSN if c is '='. 
> * doc/internals.texi (TC_EQUAL_IN_INSN):  Pass current string instead of
> input_line_pointer.

Approved.

>   If you define this macro, it should return nonzero if the instruction is
>   permitted to contain an @kbd{=} character.  GAS will call it with two
>   arguments, the character before the @kbd{=} character, and the value of
> ! @code{s} at that point.  GAS uses this macro to decide if a
>   @kbd{=} is an assignment or an instruction.

How about "and the string that follows after the equals sign" ?

Cheers
   Nick