[PATCH] small cleanup in ARC backend.

[PATCH] small cleanup in ARC backend.

[Ramana Radhakrishnan]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Hi,

This is a small cleanup in the ARC backend.It is consistent with what GCC
generates and the GAS testcase for st.s .(In the process added a testcase
for this in testsuite/gas/arc/ld.s .)

Can I commit this as obvious ?

cheers
Ramana


----
Ramana Radhakrishnan
GNU Tools
(codito ergo sum)Codito Technologies

[-- Attachment #2: chlg --]
[-- Type: application/octet-stream, Size: 277 bytes --]

2005-03-02  Ramana Radhakrishnan  <ramana.radhakrishnan@codito.com>

	* config/tc-arc.c(md_assemble): Remove dead code for checking
	on operands for ld and st.
	* testsuite/gas/arc/ld.s: Handle immediate indexed loads
	* testsuite/gas/arc/ld.d: Handle immediate indexed loads


[-- Attachment #3: arc-trivial-cleanup-gas --]
[-- Type: application/octet-stream, Size: 2180 bytes --]

Index: tc-arc.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-arc.c,v
retrieving revision 1.32
diff -c -3 -p -r1.32 tc-arc.c
*** tc-arc.c	1 Mar 2005 15:05:25 -0000	1.32
--- tc-arc.c	2 Mar 2005 17:11:15 -0000
*************** md_assemble (str)
*** 436,450 ****
  	  /* Non operand chars must match exactly.  */
  	  if (*syn != '%' || *++syn == '%')
  	    {
! 	      /* Handle '+' specially as we want to allow "ld r0,[sp-4]".  */
! 	      /* ??? The syntax has changed to [sp,-4].  */
! 	      if (0 && *syn == '+' && *str == '-')
! 		{
! 		  /* Skip over syn's +, but leave str's - alone.
! 		     That makes the case identical to "ld r0,[sp+-4]".  */
! 		  ++syn;
! 		}
! 	      else if (*str == *syn)
  		{
  		  if (*syn == ' ')
  		    past_opcode_p = 1;
--- 436,442 ----
  	  /* Non operand chars must match exactly.  */
  	  if (*syn != '%' || *++syn == '%')
  	    {
! 	     if (*str == *syn)
  		{
  		  if (*syn == ' ')
  		    past_opcode_p = 1;
Index: gas/testsuite/gas/arc/ld.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/arc/ld.s,v
retrieving revision 1.3
diff -c -3 -p -r1.3 ld.s
*** gas/testsuite/gas/arc/ld.s	22 Nov 2004 17:44:03 -0000	1.3
--- gas/testsuite/gas/arc/ld.s	2 Mar 2005 17:26:59 -0000
***************
*** 6,8 ****
--- 6,10 ----
  	ldw.x	r1,[r2,r3]
  	ldw.x.a	r2,[r3,r4]
  	ld	r0,[0]
+         ld      r0,[r1,30]
+         ld      r1,[r2,-20]
Index: gas/testsuite/gas/arc/ld.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/arc/ld.d,v
retrieving revision 1.3
diff -c -3 -p -r1.3 ld.d
*** gas/testsuite/gas/arc/ld.d	22 Nov 2004 17:44:02 -0000	1.3
--- gas/testsuite/gas/arc/ld.d	2 Mar 2005 17:26:59 -0000
*************** Disassembly of section .text:
*** 12,14 ****
--- 12,16 ----
     c:	05 06 21 00 	00210605     ldw.x      r1,\[r2,r3\]
    10:	0d 88 41 00 	0041880d     ldw.x.a    r2,\[r3,r4\]
    14:	00 80 1f 08 	081f8000     ld         r0,\[0\]
+   18:	1e 80 00 08 	0800801e     ld         r0,\[r1,30\]
+   1c:	ec 01 21 08 	082101ec     ld         r1,\[r2,-20\]

Re: [PATCH] small cleanup in ARC backend.

[Alan Modra]

On Wed, Mar 02, 2005 at 11:03:39PM +0530, Ramana Radhakrishnan wrote:
> This is a small cleanup in the ARC backend.It is consistent with what GCC
> generates and the GAS testcase for st.s .(In the process added a testcase
> for this in testsuite/gas/arc/ld.s .)
> 
> Can I commit this as obvious ?

Yes, I'd say this patch easily meets the requirements for "obvious".

When you commit the testcase, please put the changelog entry for it
into gas/testsuite/ChangeLog, not gas/ChangeLog.  Tweak the entry
itself to remove the leading "testsuite/" component of the path name
too.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: [PATCH] small cleanup in ARC backend.

[Ramana Radhakrishnan]

Hi Alan,

> Yes, I'd say this patch easily meets the requirements for "obvious".
> 
> When you commit the testcase, please put the changelog entry for it
> into gas/testsuite/ChangeLog, not gas/ChangeLog.  Tweak the entry
> itself to remove the leading "testsuite/" component of the path name
> too.
> 

Thanks ! Done ! .

cheers
Ramana

-- 
Ramana Radhakrishnan
GNU Tools
codito ergo sum (www.codito.com)