From: Michael Eager <eager@eagercon.com>
To: Neal Frager <neal.frager@amd.com>, binutils@sourceware.org
Cc: ibai.erkiaga-elorza@amd.com, nagaraju.mekala@amd.com,
mark.hatle@amd.com, sadanand.mutyala@amd.com,
appa.rao.nali@amd.com, vidhumouli.hunsigida@amd.com,
luca.ceresoli@bootlin.com, nickc@redhat.com, mark@klomp.org,
eager@eagerm.com, macro@orcam.me.uk
Subject: Re: [PATCH v5 1/1] opcodes: microblaze: Add new bit-field instructions
Date: Tue, 10 Oct 2023 11:03:42 -0700 [thread overview]
Message-ID: <4297d8dd-f276-6547-abe7-edea6c9270aa@eagercon.com> (raw)
In-Reply-To: <20231010075906.2185416-1-neal.frager@amd.com>
On 10/10/23 00:59, Neal Frager wrote:
> This patches adds new bsefi and bsifi instructions.
> BSEFI- The instruction shall extract a bit field from a
> register and place it right-adjusted in the destination register.
> The other bits in the destination register shall be set to zero.
> BSIFI- The instruction shall insert a right-adjusted bit field
> from a register at another position in the destination register.
> The rest of the bits in the destination register shall be unchanged.
>
> Further documentation of these instructions can be found here:
> https://docs.xilinx.com/v/u/en-US/ug984-vivado-microblaze-ref
>
> This patch has been tested for years of AMD Xilinx Yocto
> releases as part of the following patch set:
>
> https://github.com/Xilinx/meta-xilinx/tree/master/meta-microblaze/recipes-devtools/binutils/binutils
>
> Signed-off-by: nagaraju <nagaraju.mekala@amd.com>
> Signed-off-by: Ibai Erkiaga <ibai.erkiaga-elorza@amd.com>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> V1->V2:
> -corrected relocation values for the linker
> V2->V3:
> - fixed build issue for 32-bit hosts
> - added test cases for bsefi and bsifi instructions
> V3->V4:
> - fixed GNU coding standard issues
> V4->V5:
> - fixed a remaining line of code > 80 chars
Please do NOT send me incremental changes to this (or any other) patch.
They clutter up my inbox and I will not review or apply incomplete patches.
Please provide a FINAL patch which addresses all of the issues
previously noted.
Include the summary of the binutils test suite runs (gas, ld, binutils)
or a diff of the .sum file, before and after applying the patch, showing
no regressions.
--
Michael Eager
prev parent reply other threads:[~2023-10-10 18:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 7:59 Neal Frager
2023-10-10 18:03 ` Michael Eager [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4297d8dd-f276-6547-abe7-edea6c9270aa@eagercon.com \
--to=eager@eagercon.com \
--cc=appa.rao.nali@amd.com \
--cc=binutils@sourceware.org \
--cc=eager@eagerm.com \
--cc=ibai.erkiaga-elorza@amd.com \
--cc=luca.ceresoli@bootlin.com \
--cc=macro@orcam.me.uk \
--cc=mark.hatle@amd.com \
--cc=mark@klomp.org \
--cc=nagaraju.mekala@amd.com \
--cc=neal.frager@amd.com \
--cc=nickc@redhat.com \
--cc=sadanand.mutyala@amd.com \
--cc=vidhumouli.hunsigida@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).