Re: [PATCH 1/7] Fix size of external_reloc for pe-aarch64

[Christophe Lyon <christophe.lyon@arm.com>]

Hi!

I am not a maintainer, but would you mind adding proper commit messages 
describing what each patch does (or intends to)?

Thanks,

Christophe


On 1/6/23 02:25, Mark Harmstone wrote:
> Resubmission of aarch64-w64-mingw32 patches against Nick's arm64pe patch.
> 
> ---
>   bfd/coff-aarch64.c     | 4 ----
>   include/coff/aarch64.h | 3 +--
>   2 files changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/bfd/coff-aarch64.c b/bfd/coff-aarch64.c
> index 8a514b278ee..236cbb79ffb 100644
> --- a/bfd/coff-aarch64.c
> +++ b/bfd/coff-aarch64.c
> @@ -188,10 +188,6 @@ coff_aarch64_rtype_lookup (unsigned int code)
>   #define bfd_pe_print_pdata      NULL
>   #endif
>   
> -/* Handle include/coff/aarch64.h external_reloc.  */
> -#define SWAP_IN_RELOC_OFFSET	H_GET_32
> -#define SWAP_OUT_RELOC_OFFSET	H_PUT_32
> -
>   /* Return TRUE if this relocation should
>      appear in the output .reloc section.  */
>   
> diff --git a/include/coff/aarch64.h b/include/coff/aarch64.h
> index 7592661553f..4616cfef2b8 100644
> --- a/include/coff/aarch64.h
> +++ b/include/coff/aarch64.h
> @@ -54,11 +54,10 @@ struct external_reloc
>     char r_vaddr[4];
>     char r_symndx[4];
>     char r_type[2];
> -  char r_offset[4];
>   };
>   
>   #define RELOC struct external_reloc
> -#define RELSZ 14
> +#define RELSZ 10
>   
>   /* ARM64 relocations types. */
>