public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH, ARM] Fix disassembly of 32-bit immediates for VMOV, etc.  on 64-bit hosts
@ 2006-06-09 17:01 Julian Brown
  2006-06-12 11:00 ` Nick Clifton
  0 siblings, 1 reply; 2+ messages in thread
From: Julian Brown @ 2006-06-09 17:01 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi,

This patch fixes some testsuite failures where differences in the size 
of long lead to differences in disassembly on arm-none-eabi. This patch 
leads to the same behaviour as 32-bit hosts -- top-bit-set constants are 
output as signed rather than unsigned integers.

OK to apply?

Cheers,

Julian

ChangeLog (opcodes):

     * arm-dis.c (print_insn_neon): Disassemble 32-bit immediates as
     signed on 64-bit hosts.

[-- Attachment #2: neon-opcodes-64bit-host-1 --]
[-- Type: text/plain, Size: 977 bytes --]

Index: arm-dis.c
===================================================================
RCS file: /cvs/src/src/opcodes/arm-dis.c,v
retrieving revision 1.66
diff -c -p -r1.66 arm-dis.c
*** arm-dis.c	7 Jun 2006 14:08:19 -0000	1.66
--- arm-dis.c	9 Jun 2006 16:42:08 -0000
*************** print_insn_neon (struct disassemble_info
*** 2417,2423 ****
                                        value);
                                }
                              else
!                               func (stream, "#%ld\t; 0x%.8lx", value, value);
                              break;
  
                            case 64:
--- 2417,2425 ----
                                        value);
                                }
                              else
!                               func (stream, "#%ld\t; 0x%.8lx",
! 				(long) ((value & 0x80000000)
! 					? value | ~0xffffffffl : value), value);
                              break;
  
                            case 64:

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH, ARM] Fix disassembly of 32-bit immediates for VMOV, etc.   on 64-bit hosts
  2006-06-09 17:01 [PATCH, ARM] Fix disassembly of 32-bit immediates for VMOV, etc. on 64-bit hosts Julian Brown
@ 2006-06-12 11:00 ` Nick Clifton
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2006-06-12 11:00 UTC (permalink / raw)
  To: Julian Brown; +Cc: binutils

Hi Julian,

> ChangeLog (opcodes):
> 
>     * arm-dis.c (print_insn_neon): Disassemble 32-bit immediates as
>     signed on 64-bit hosts.

Approved - please apply.

Cheers
   Nick

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-06-12 10:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-09 17:01 [PATCH, ARM] Fix disassembly of 32-bit immediates for VMOV, etc. on 64-bit hosts Julian Brown
2006-06-12 11:00 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).