From: Jan Beulich <jbeulich@suse.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Nick Clifton <nickc@redhat.com>,
"ramana.radhakrishnan@arm.com" <ramana.radhakrishnan@arm.com>,
Richard Earnshaw <rearnsha@arm.com>,
Marcus Shawcroft <marcus.shawcroft@arm.com>,
Alan Modra <amodra@gmail.com>,
Peter Bergner <bergner@vnet.ibm.com>,
Geoff Keating <geoffk@geoffk.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Nelson Chu <nelson@rivosinc.com>, "H.J. Lu" <hjl.tools@gmail.com>,
Luis Machado <luis.machado@arm.com>,
Binutils <binutils@sourceware.org>
Subject: Re: [PATCH v2 2/2] gas: re-work line number tracking for macros and their expansions
Date: Thu, 15 Dec 2022 09:28:51 +0100 [thread overview]
Message-ID: <45290c42-f30a-ca1b-efb5-6283caaa172b@suse.com> (raw)
In-Reply-To: <87a63p2a81.fsf@redhat.com>
On 14.12.2022 17:58, Andrew Burgess wrote:
> I think I understand the issue a little more now. I have a simple
> reproducer which can be run outside the gdb testsuite (see below).
>
> It appears that the DWARF for macros now tries to associate the
> instructions within the macro the source location within the macro
> definition, rather than the macro use site. I'm not entirely convinced
> this is a good idea (as a macro could be used multiple times), or even
> if this was an intended change of this series.
No, there was no intention to alter generated Dwarf. In fact I had put in
place a test ahead of this change here (commit 6fdb723799e2) to have at
least some proof of that. Quite likely that wasn't elaborate enough a test
then.
> If this is the direction gas is moving in then I guess we will need to
> update the GDB test, but there is, I think, a bug in the generated
> DWARF, in that it appears that the wrong file name is being used.
While I would like to improve representation of .macro expansions, we
first need to determine what the best way is for representing them. See
also the post-commit-message remark in the submission of the patch here.
Jan
next prev parent reply other threads:[~2022-12-15 8:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 10:47 [PATCH v2 0/2] gas: diagnostic improvements for macros Jan Beulich
2022-12-09 10:49 ` [PATCH v2 1/2] Arm: avoid unhelpful uses of .macro in testsuite Jan Beulich
2022-12-09 10:52 ` [PATCH v2 2/2] gas: re-work line number tracking for macros and their expansions Jan Beulich
2022-12-14 14:03 ` Luis Machado
2022-12-14 14:13 ` Luis Machado
2022-12-14 16:00 ` Andrew Burgess
2022-12-14 16:58 ` Andrew Burgess
2022-12-15 8:28 ` Jan Beulich [this message]
2022-12-15 10:50 ` Jan Beulich
2022-12-15 17:00 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45290c42-f30a-ca1b-efb5-6283caaa172b@suse.com \
--to=jbeulich@suse.com \
--cc=aburgess@redhat.com \
--cc=amodra@gmail.com \
--cc=andrew@sifive.com \
--cc=bergner@vnet.ibm.com \
--cc=binutils@sourceware.org \
--cc=geoffk@geoffk.org \
--cc=hjl.tools@gmail.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=luis.machado@arm.com \
--cc=marcus.shawcroft@arm.com \
--cc=nelson@rivosinc.com \
--cc=nickc@redhat.com \
--cc=palmer@dabbelt.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).