public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Cc: Nick Clifton <nickc@redhat.com>, Alan Modra <amodra@gmail.com>,
	Richard Earnshaw <rearnsha@arm.com>,
	Marcus Shawcroft <marcus.shawcroft@arm.com>
Subject: [PATCH 02/22] Arm64: drop .bss override
Date: Fri, 15 Dec 2023 13:06:52 +0100	[thread overview]
Message-ID: <45bac99c-1481-4c0e-a38a-2ab583cadb55@suse.com> (raw)
In-Reply-To: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com>

The comment looks bogus (perhaps simply stale, perhaps wrongly copied
from Arm in the first place), and there are also no other precautions
against subsections being used on ELF with .bss. It also doesn't look
to be a good idea to override the custom handlers that ELF and COFF
have (afaict doing so further broke .previous on ELF).

As to the mapping state update - such also doesn't appear to be done
for other section switching, so its original purpose was at best
questionable as well.

--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -1866,17 +1866,7 @@ mapping_state_2 (enum mstate state, int
 #define mapping_state_2(x, y)	/* nothing */
 #endif
 
-/* Directives: sectioning and alignment.  */
-
-static void
-s_bss (int ignore ATTRIBUTE_UNUSED)
-{
-  /* We don't support putting frags in the BSS segment, we fake it by
-     marking in_bss, then looking at s_skip for clues.  */
-  subseg_set (bss_section, 0);
-  demand_empty_rest_of_line ();
-  mapping_state (MAP_DATA);
-}
+/* Directives: alignment.  */
 
 static void
 s_even (int ignore ATTRIBUTE_UNUSED)
@@ -2396,7 +2386,6 @@ const pseudo_typeS md_pseudo_table[] = {
   /* Never called because '.req' does not start a line.  */
   {"req", s_req, 0},
   {"unreq", s_unreq, 0},
-  {"bss", s_bss, 0},
   {"even", s_even, 0},
   {"ltorg", s_ltorg, 0},
   {"pool", s_ltorg, 0},
--- a/gas/doc/c-aarch64.texi
+++ b/gas/doc/c-aarch64.texi
@@ -389,11 +389,6 @@ extensions by the @option{-mcpu} command
 incrementally to the architecture being compiled for.
 
 @c BBBBBBBBBBBBBBBBBBBBBBBBBB
-
-@cindex @code{.bss} directive, AArch64
-@item .bss
-This directive switches to the @code{.bss} section.
-
 @c CCCCCCCCCCCCCCCCCCCCCCCCCC
 
 @cindex @code{.cpu} directive, AArch64


  parent reply	other threads:[~2023-12-15 12:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15 11:59 [PATCH 00/22] ELF: correct handling of simplified section directives Jan Beulich
2023-12-15 12:06 ` [PATCH 01/22] Arm: drop .bss override Jan Beulich
2023-12-15 12:06 ` Jan Beulich [this message]
2023-12-15 12:07 ` [PATCH 03/22] RISC-V: " Jan Beulich
2023-12-21  6:44   ` Nelson Chu
2023-12-15 12:08 ` [PATCH 04/22] IA64: " Jan Beulich
2023-12-15 12:09 ` [PATCH 05/22] bfin: " Jan Beulich
2023-12-15 12:10 ` [PATCH 06/22] m32c: " Jan Beulich
2023-12-15 12:10 ` [PATCH 07/22] m68k: " Jan Beulich
2023-12-15 12:11 ` [PATCH 08/22] microblaze: drop/restrict override of .text, .data, and .bss Jan Beulich
2023-12-15 12:12 ` [PATCH 09/22] rl78: drop .bss override Jan Beulich
2023-12-15 12:12 ` [PATCH 10/22] rx: " Jan Beulich
2023-12-15 12:13 ` [PATCH 11/22] s390: " Jan Beulich
2023-12-15 12:14 ` [PATCH 12/22] score: " Jan Beulich
2023-12-15 12:15 ` [PATCH 13/22] visium: drop .bss and .skip overrides Jan Beulich
2023-12-15 12:16 ` [PATCH 14/22] z80: drop .bss override Jan Beulich
2023-12-15 12:16 ` [PATCH 15/22] ELF: test certain .bss usages Jan Beulich
2023-12-15 12:16 ` [PATCH 16/22] gas: correct .bss documentation for non-ELF Jan Beulich
2023-12-15 12:17 ` [PATCH 17/22] v850: drop .bss override Jan Beulich
2023-12-15 12:18 ` [PATCH 18/22] d30v: fix .text/.data interaction with .previous Jan Beulich
2023-12-15 12:19 ` [PATCH 19/22] hppa/ELF: " Jan Beulich
2023-12-15 16:37   ` John David Anglin
2023-12-15 12:19 ` [PATCH 20/22] nios2: " Jan Beulich
2023-12-15 19:00   ` Sandra Loosemore
2023-12-15 12:20 ` [PATCH 21/22] pru: " Jan Beulich
2023-12-15 12:20 ` [PATCH 22/22] ELF: test certain .text/.data usages Jan Beulich
2024-01-02  0:40 ` [PATCH 00/22] ELF: correct handling of simplified section directives Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45bac99c-1481-4c0e-a38a-2ab583cadb55@suse.com \
    --to=jbeulich@suse.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=marcus.shawcroft@arm.com \
    --cc=nickc@redhat.com \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).