public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Cc: Nick Clifton <nickc@redhat.com>, Alan Modra <amodra@gmail.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Andrew Waterman <andrew@sifive.com>,
	Jim Wilson <jim.wilson.gcc@gmail.com>,
	Nelson Chu <nelson@rivosinc.com>
Subject: [PATCH 03/22] RISC-V: drop .bss override
Date: Fri, 15 Dec 2023 13:07:28 +0100	[thread overview]
Message-ID: <aada12dc-7679-4dd3-97be-a8f429020c90@suse.com> (raw)
In-Reply-To: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com>

It doesn't look to be a good idea to override the custom handler that
ELF has; afaict doing so broke .previous, and a sub-section specifier
wasn't accepted either.

--- a/gas/config/tc-riscv.c
+++ b/gas/config/tc-riscv.c
@@ -4471,15 +4471,6 @@ s_dtprel (int bytes)
   demand_empty_rest_of_line ();
 }
 
-/* Handle the .bss pseudo-op.  */
-
-static void
-s_bss (int ignore ATTRIBUTE_UNUSED)
-{
-  subseg_set (bss_section, 0);
-  demand_empty_rest_of_line ();
-}
-
 static void
 riscv_make_nops (char *buf, bfd_vma bytes)
 {
@@ -5202,7 +5193,6 @@ static const pseudo_typeS riscv_pseudo_t
   {"dword", cons, 8},
   {"dtprelword", s_dtprel, 4},
   {"dtpreldword", s_dtprel, 8},
-  {"bss", s_bss, 0},
   {"uleb128", s_riscv_leb128, 0},
   {"sleb128", s_riscv_leb128, 1},
   {"insn", s_riscv_insn, 0},
--- a/gas/doc/c-riscv.texi
+++ b/gas/doc/c-riscv.texi
@@ -138,10 +138,6 @@ Emits a DTP-relative word (or double-wor
 meant to be used by the compiler in shared libraries for DWARF debug info for
 thread local variables.
 
-@cindex BSS directive
-@item .bss
-Sets the current section to the BSS section.
-
 @cindex LEB128 directives
 @item .uleb128 @var{value}
 @itemx .sleb128 @var{value}


  parent reply	other threads:[~2023-12-15 12:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15 11:59 [PATCH 00/22] ELF: correct handling of simplified section directives Jan Beulich
2023-12-15 12:06 ` [PATCH 01/22] Arm: drop .bss override Jan Beulich
2023-12-15 12:06 ` [PATCH 02/22] Arm64: " Jan Beulich
2023-12-15 12:07 ` Jan Beulich [this message]
2023-12-21  6:44   ` [PATCH 03/22] RISC-V: " Nelson Chu
2023-12-15 12:08 ` [PATCH 04/22] IA64: " Jan Beulich
2023-12-15 12:09 ` [PATCH 05/22] bfin: " Jan Beulich
2023-12-15 12:10 ` [PATCH 06/22] m32c: " Jan Beulich
2023-12-15 12:10 ` [PATCH 07/22] m68k: " Jan Beulich
2023-12-15 12:11 ` [PATCH 08/22] microblaze: drop/restrict override of .text, .data, and .bss Jan Beulich
2023-12-15 12:12 ` [PATCH 09/22] rl78: drop .bss override Jan Beulich
2023-12-15 12:12 ` [PATCH 10/22] rx: " Jan Beulich
2023-12-15 12:13 ` [PATCH 11/22] s390: " Jan Beulich
2023-12-15 12:14 ` [PATCH 12/22] score: " Jan Beulich
2023-12-15 12:15 ` [PATCH 13/22] visium: drop .bss and .skip overrides Jan Beulich
2023-12-15 12:16 ` [PATCH 14/22] z80: drop .bss override Jan Beulich
2023-12-15 12:16 ` [PATCH 15/22] ELF: test certain .bss usages Jan Beulich
2023-12-15 12:16 ` [PATCH 16/22] gas: correct .bss documentation for non-ELF Jan Beulich
2023-12-15 12:17 ` [PATCH 17/22] v850: drop .bss override Jan Beulich
2023-12-15 12:18 ` [PATCH 18/22] d30v: fix .text/.data interaction with .previous Jan Beulich
2023-12-15 12:19 ` [PATCH 19/22] hppa/ELF: " Jan Beulich
2023-12-15 16:37   ` John David Anglin
2023-12-15 12:19 ` [PATCH 20/22] nios2: " Jan Beulich
2023-12-15 19:00   ` Sandra Loosemore
2023-12-15 12:20 ` [PATCH 21/22] pru: " Jan Beulich
2023-12-15 12:20 ` [PATCH 22/22] ELF: test certain .text/.data usages Jan Beulich
2024-01-02  0:40 ` [PATCH 00/22] ELF: correct handling of simplified section directives Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aada12dc-7679-4dd3-97be-a8f429020c90@suse.com \
    --to=jbeulich@suse.com \
    --cc=amodra@gmail.com \
    --cc=andrew@sifive.com \
    --cc=binutils@sourceware.org \
    --cc=jim.wilson.gcc@gmail.com \
    --cc=nelson@rivosinc.com \
    --cc=nickc@redhat.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).