public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] pru: bfd: Correct default to no execstack
@ 2022-11-12  9:12 Dimitar Dimitrov
  2022-11-14 13:52 ` Nick Clifton
  0 siblings, 1 reply; 2+ messages in thread
From: Dimitar Dimitrov @ 2022-11-12  9:12 UTC (permalink / raw)
  To: binutils; +Cc: Dimitar Dimitrov

Data and instruction memories are strictly separated, so it is not
possible to execute instructions from the stack memory on PRU.

I don't see any difference in testsuite results with or without this
change.

Ok for trunk?

bfd/ChangeLog:

	* elf32-pru.c (elf_backend_default_execstack): Define as 0.

ld/ChangeLog:

	* testsuite/ld-elf/elf.exp (target_defaults_to_execstack):
	Return 0 for pru.

Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
 bfd/elf32-pru.c             | 2 ++
 ld/testsuite/ld-elf/elf.exp | 1 +
 2 files changed, 3 insertions(+)

diff --git a/bfd/elf32-pru.c b/bfd/elf32-pru.c
index 7a75fbd5036..a6ce478f4e2 100644
--- a/bfd/elf32-pru.c
+++ b/bfd/elf32-pru.c
@@ -1603,6 +1603,8 @@ pru_elf32_link_hash_table_create (bfd *abfd)
 #define bfd_elf32_bfd_relax_section	pru_elf32_relax_section
 #define elf_backend_can_gc_sections	1
 
+#define elf_backend_default_execstack	0
+
 #define TARGET_LITTLE_SYM		pru_elf32_vec
 #define TARGET_LITTLE_NAME		"elf32-pru"
 
diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp
index e4d8bee2f53..f9c74bf6bed 100644
--- a/ld/testsuite/ld-elf/elf.exp
+++ b/ld/testsuite/ld-elf/elf.exp
@@ -187,6 +187,7 @@ proc target_defaults_to_execstack {} {
 	|| [istarget "loongarch*-*-*"]
 	|| [istarget "nios2*-*-*"]
 	|| [istarget "powerpc64*-*-*"]
+	|| [istarget "pru*-*-*"]
 	|| [istarget "riscv*-*-*"]
 	|| [istarget "tilegx*-*-*"]
 	|| [istarget "tilepro*-*-*"] } {
-- 
2.38.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] pru: bfd: Correct default to no execstack
  2022-11-12  9:12 [PATCH] pru: bfd: Correct default to no execstack Dimitar Dimitrov
@ 2022-11-14 13:52 ` Nick Clifton
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2022-11-14 13:52 UTC (permalink / raw)
  To: Dimitar Dimitrov, binutils

Hi Dimitar,

> Data and instruction memories are strictly separated, so it is not
> possible to execute instructions from the stack memory on PRU.
> 
> I don't see any difference in testsuite results with or without this
> change.
> 
> Ok for trunk?
> 
> bfd/ChangeLog:
> 
> 	* elf32-pru.c (elf_backend_default_execstack): Define as 0.
> 
> ld/ChangeLog:
> 
> 	* testsuite/ld-elf/elf.exp (target_defaults_to_execstack):
> 	Return 0 for pru.

Approved - please apply.

Cheers
   Nick


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-14 13:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-12  9:12 [PATCH] pru: bfd: Correct default to no execstack Dimitar Dimitrov
2022-11-14 13:52 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).