* [PATCH] s390: Flag conditional branch relative insns as condjump
@ 2024-04-04 12:24 Jens Remus
2024-04-09 8:13 ` Nick Clifton
0 siblings, 1 reply; 3+ messages in thread
From: Jens Remus @ 2024-04-04 12:24 UTC (permalink / raw)
To: binutils, Andreas Krebbel; +Cc: Jens Remus
Flag conditional branch relative (extended) mnemonics clij* and clgij*
as "condjump" for jump visualization in disassembly. They were missed
to be flagged as such in commit c5306fed7d40 ("s390: Support for jump
visualization in disassembly").
opcodes/
* s390-opc.txt: Flag conditional branch relative instructions
clij* and clgij* as condjump for jump visualization in
disassembly.
Signed-off-by: Jens Remus <jremus@linux.ibm.com>
---
opcodes/s390-opc.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/opcodes/s390-opc.txt b/opcodes/s390-opc.txt
index 83ca22f6fac3..1182e196059b 100644
--- a/opcodes/s390-opc.txt
+++ b/opcodes/s390-opc.txt
@@ -942,10 +942,10 @@ ec00000000ff clib$12 RIS_R0RDU "compare logical immediate and branch (32<8)" z10
ec00000000ff clib RIS_RURDU "compare logical immediate and branch (32<8)" z10 zarch
ec00000000fd clgib$12 RIS_R0RDU "compare logical immediate and branch (64<8)" z10 zarch
ec00000000fd clgib RIS_RURDU "compare logical immediate and branch (64<8)" z10 zarch
-ec000000007f clij$12 RIE_R0PU "compare logical immediate and branch relative (32<8)" z10 zarch
-ec000000007f clij RIE_RUPU "compare logical immediate and branch relative (32<8)" z10 zarch
-ec000000007d clgij$12 RIE_R0PU "compare logical immediate and branch relative (64<8)" z10 zarch
-ec000000007d clgij RIE_RUPU "compare logical immediate and branch relative (64<8)" z10 zarch
+ec000000007f clij$12 RIE_R0PU "compare logical immediate and branch relative (32<8)" z10 zarch condjump
+ec000000007f clij RIE_RUPU "compare logical immediate and branch relative (32<8)" z10 zarch condjump
+ec000000007d clgij$12 RIE_R0PU "compare logical immediate and branch relative (64<8)" z10 zarch condjump
+ec000000007d clgij RIE_RUPU "compare logical immediate and branch relative (64<8)" z10 zarch condjump
b9730000 clrt$16 RRF_00RR "compare logical and trap (32)" z10 zarch
b973 clrt RRF_U0RR "compare logical and trap (32)" z10 zarch
b9610000 clgrt$16 RRF_00RR "compare logical and trap (64)" z10 zarch
--
2.40.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390: Flag conditional branch relative insns as condjump
2024-04-04 12:24 [PATCH] s390: Flag conditional branch relative insns as condjump Jens Remus
@ 2024-04-09 8:13 ` Nick Clifton
2024-04-09 15:19 ` Jens Remus
0 siblings, 1 reply; 3+ messages in thread
From: Nick Clifton @ 2024-04-09 8:13 UTC (permalink / raw)
To: Jens Remus, binutils, Andreas Krebbel
Hi Jens,
> Flag conditional branch relative (extended) mnemonics clij* and clgij*
> as "condjump" for jump visualization in disassembly. They were missed
> to be flagged as such in commit c5306fed7d40 ("s390: Support for jump
> visualization in disassembly").
>
> opcodes/
> * s390-opc.txt: Flag conditional branch relative instructions
> clij* and clgij* as condjump for jump visualization in
> disassembly.
>
> Signed-off-by: Jens Remus <jremus@linux.ibm.com>
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390: Flag conditional branch relative insns as condjump
2024-04-09 8:13 ` Nick Clifton
@ 2024-04-09 15:19 ` Jens Remus
0 siblings, 0 replies; 3+ messages in thread
From: Jens Remus @ 2024-04-09 15:19 UTC (permalink / raw)
To: binutils; +Cc: Nick Clifton, Andreas Krebbel
Am 09.04.2024 um 10:13 schrieb Nick Clifton:
> Hi Jens,
>
>> Flag conditional branch relative (extended) mnemonics clij* and clgij*
>> as "condjump" for jump visualization in disassembly. They were missed
>> to be flagged as such in commit c5306fed7d40 ("s390: Support for jump
>> visualization in disassembly").
>>
>> opcodes/
>> * s390-opc.txt: Flag conditional branch relative instructions
>> clij* and clgij* as condjump for jump visualization in
>> disassembly.
>>
>> Signed-off-by: Jens Remus <jremus@linux.ibm.com>
>
> Approved - please apply.
Thank you! Done.
Regards,
Jens
--
Jens Remus
Linux on Z Development (D3303) and z/VSE Support
+49-7031-16-1128 Office
jremus@de.ibm.com
IBM
IBM Deutschland Research & Development GmbH; Vorsitzender des
Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der
Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-09 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-04 12:24 [PATCH] s390: Flag conditional branch relative insns as condjump Jens Remus
2024-04-09 8:13 ` Nick Clifton
2024-04-09 15:19 ` Jens Remus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).