From: Nick Clifton <nickc@redhat.com>
To: mengqinggang <mengqinggang@loongson.cn>, binutils@sourceware.org
Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn,
liuzhensong@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name,
maskray@google.com
Subject: Re: [PATCH] Symbols with GOT relocatios do not fix adjustbale
Date: Tue, 18 Apr 2023 11:51:07 +0100 [thread overview]
Message-ID: <515667f3-5309-d89e-f44b-d4b3d7d96e28@redhat.com> (raw)
In-Reply-To: <20230414061935.1252692-1-mengqinggang@loongson.cn>
Hi mengqinggang,
> If a local symbol loaded by GOT, do not fix adjustbale to avoid GOT
> relocations' addend not equal to zero.
>
> gas/ChangeLog:
>
> * config/tc-loongarch.c (loongarch_fix_adjustable): Symbols with
> GOT relocatios do not fix adjustbale.
> * testsuite/gas/loongarch/macro_op_large_abs.d: Regenerated.
> * testsuite/gas/loongarch/macro_op_large_pc.d: Regenerated.
>
> ld/ChangeLog:
>
> * testsuite/ld-loongarch-elf/macro_op.d: Regenerated.
Patch approved and applied.
Thanks very much for contributing to the binutils.
Cheers
Nick
prev parent reply other threads:[~2023-04-18 10:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 6:19 mengqinggang
2023-04-18 10:51 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515667f3-5309-d89e-f44b-d4b3d7d96e28@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=chenglulu@loongson.cn \
--cc=i.swmail@xen0n.name \
--cc=liuzhensong@loongson.cn \
--cc=maskray@google.com \
--cc=mengqinggang@loongson.cn \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).