From: Nick Clifton <nickc@redhat.com>
To: Neal Frager <neal.frager@amd.com>, binutils@sourceware.org
Cc: ibai.erkiaga-elorza@amd.com, nagaraju.mekala@amd.com,
mark.hatle@amd.com, sadanand.mutyala@amd.com,
appa.rao.nali@amd.com
Subject: Re: [PATCH v1 1/1] opcodes: microblaze: Add wdc.ext.clear and wdc.ext.flush insns
Date: Wed, 27 Sep 2023 14:49:08 +0100 [thread overview]
Message-ID: <54010468-6534-37e0-996f-b199fb8a4214@redhat.com> (raw)
In-Reply-To: <20230925092244.3449756-1-neal.frager@amd.com>
Hi Neal,
> Added two new instructions, wdc.ext.clear and wdc.ext.flush,
> to enable MicroBlaze to flush an external cache, which is
> used with the new coherency support for multiprocessing.
Patch approved and applied.
One small question:
> + {"wdc.ext.clear", INST_TYPE_R1_R2_SPECIAL, INST_NO_OFFSET, NO_DELAY_SLOT, IMMVAL_MASK_NON_SPECIAL, 0x90000466, OPCODE_MASK_H35B, wdcextclear, special_inst }
This new line omits a comma at the end. Was this deliberate ?
I have assumed that it was just a typo and added one, but if there is
a good reason to omit the comma, please let me know and I will correct
the pushed patch.
Cheers
Nick
next prev parent reply other threads:[~2023-09-27 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 9:22 Neal Frager
2023-09-27 13:49 ` Nick Clifton [this message]
2023-09-27 13:52 ` Frager, Neal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54010468-6534-37e0-996f-b199fb8a4214@redhat.com \
--to=nickc@redhat.com \
--cc=appa.rao.nali@amd.com \
--cc=binutils@sourceware.org \
--cc=ibai.erkiaga-elorza@amd.com \
--cc=mark.hatle@amd.com \
--cc=nagaraju.mekala@amd.com \
--cc=neal.frager@amd.com \
--cc=sadanand.mutyala@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).