From: Nick Clifton <nickc@redhat.com>
To: Jojo R <rjiejie@linux.alibaba.com>, binutils@sourceware.org
Subject: Re: [PATCH] Support multiple .eh_frame sections
Date: Mon, 1 Aug 2022 12:10:49 +0100 [thread overview]
Message-ID: <56cde846-f34f-72dc-7641-4bba6f544b06@redhat.com> (raw)
In-Reply-To: <20220729074837.82957-1-rjiejie@linux.alibaba.com>
Hi Jojo,
> This patch is based on MULTIPLE_FRAME_SECTIONS and EH_FRAME_LINKONCE, > it allows backend to enable this feature and use '--gc-sections' simply.
This patch looks good to me. But there are two issues, one small, one major:
* The small issue is that you need to add an entry to the gas/doc/internals.texi
describing the new TARGET_MULTIPLE_EH_FRAME_SECTIONS macro. (I know that the
name is basically self-describing, but it is nice to keep the documentation
accurate).
* The bigger issue is that I could not find a FSF copyright assignment under
your name, or for Alibaba. We would need such an assignment before we could
accept your patch. (Note - I did find an assignment for Alibaba contributions
to gcc, so I would assume that obtaining a similar assignment for the binutils
should not be too difficult).
Cheers
Nick
next prev parent reply other threads:[~2022-08-01 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 7:48 Jojo R
2022-08-01 11:10 ` Nick Clifton [this message]
2022-08-02 7:23 ` Jojo R
2022-11-02 8:01 ` [PATCH v2] " Jojo R
2022-11-02 12:21 ` Nick Clifton
2022-11-03 2:11 ` Jojo R
2022-11-03 2:04 ` [PATCH v3] " Jojo R
2022-11-03 10:26 ` Nick Clifton
2022-11-03 19:34 ` Fangrui Song
[not found] ` <DS7PR12MB57653A2E86C6779B24889E51CB389@DS7PR12MB5765.namprd12.prod.outlook.com>
2022-11-04 1:50 ` Jojo R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56cde846-f34f-72dc-7641-4bba6f544b06@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=rjiejie@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).