[PATCH] [aarch64] sme: Core file support

[PATCH] [aarch64] sme: Core file support

[Luis Machado]

From: Ezra Sitorus <ezra.sitorus@arm.com>

Add required code to support core file dumps with NT_ARM_ZA and NT_ARM_SSVE
register sets in them.

These new register sets are dumped when SME is supported.
---
 bfd/elf-bfd.h |  4 ++++
 bfd/elf.c     | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 62 insertions(+)

diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h
index ec856764519..2a9eed7f9ee 100644
--- a/bfd/elf-bfd.h
+++ b/bfd/elf-bfd.h
@@ -2939,6 +2939,10 @@ extern char *elfcore_write_aarch_pauth
   (bfd *, char *, int *, const void *, int);
 extern char *elfcore_write_aarch_mte
   (bfd *, char *, int *, const void *, int);
+extern char *elfcore_write_aarch_ssve
+  (bfd *, char *, int *, const void *, int);
+extern char *elfcore_write_aarch_za
+  (bfd *, char *, int *, const void *, int);
 extern char *elfcore_write_arc_v2
   (bfd *, char *, int *, const void *, int);
 extern char *elfcore_write_riscv_csr
diff --git a/bfd/elf.c b/bfd/elf.c
index d38e0afff2e..2a097b02977 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -10680,6 +10680,18 @@ elfcore_grok_aarch_mte (bfd *abfd, Elf_Internal_Note *note)
 					  note);
 }
 
+static bool
+elfcore_grok_aarch_ssve (bfd *abfd, Elf_Internal_Note *note)
+{
+  return elfcore_make_note_pseudosection (abfd, ".reg-aarch-ssve", note);
+}
+
+static bool
+elfcore_grok_aarch_za (bfd *abfd, Elf_Internal_Note *note)
+{
+  return elfcore_make_note_pseudosection (abfd, ".reg-aarch-za", note);
+}
+
 static bool
 elfcore_grok_arc_v2 (bfd *abfd, Elf_Internal_Note *note)
 {
@@ -11395,6 +11407,20 @@ elfcore_grok_note (bfd *abfd, Elf_Internal_Note *note)
       else
 	return true;
 
+    case NT_ARM_SSVE:
+      if (note->namesz == 6
+	  && strcmp (note->namedata, "LINUX") == 0)
+	return elfcore_grok_aarch_ssve (abfd, note);
+      else
+	return true;
+
+    case NT_ARM_ZA:
+      if (note->namesz == 6
+	  && strcmp (note->namedata, "LINUX") == 0)
+	return elfcore_grok_aarch_za (abfd, note);
+      else
+	return true;
+
     case NT_GDB_TDESC:
       if (note->namesz == 4
 	  && strcmp (note->namedata, "GDB") == 0)
@@ -13009,6 +13035,34 @@ elfcore_write_aarch_mte (bfd *abfd,
 			     size);
 }
 
+char *
+elfcore_write_aarch_ssve (bfd *abfd,
+			  char *buf,
+			  int *bufsiz,
+			  const void *aarch_ssve,
+			  int size)
+{
+  char *note_name = "LINUX";
+  return elfcore_write_note (abfd, buf, bufsiz,
+			     note_name, NT_ARM_SSVE,
+			     aarch_ssve,
+			     size);
+}
+
+char *
+elfcore_write_aarch_za (bfd *abfd,
+			char *buf,
+			int *bufsiz,
+			const void *aarch_za,
+			int size)
+{
+  char *note_name = "LINUX";
+  return elfcore_write_note (abfd, buf, bufsiz,
+			     note_name, NT_ARM_ZA,
+			     aarch_za,
+			     size);
+}
+
 char *
 elfcore_write_arc_v2 (bfd *abfd,
 		      char *buf,
@@ -13190,6 +13244,10 @@ elfcore_write_register_note (bfd *abfd,
     return elfcore_write_aarch_pauth (abfd, buf, bufsiz, data, size);
   if (strcmp (section, ".reg-aarch-mte") == 0)
     return elfcore_write_aarch_mte (abfd, buf, bufsiz, data, size);
+  if (strcmp (section, ".reg-aarch-ssve") == 0)
+    return elfcore_write_aarch_ssve (abfd, buf, bufsiz, data, size);
+  if (strcmp (section, ".reg-aarch-za") == 0)
+    return elfcore_write_aarch_za (abfd, buf, bufsiz, data, size);
   if (strcmp (section, ".reg-arc-v2") == 0)
     return elfcore_write_arc_v2 (abfd, buf, bufsiz, data, size);
   if (strcmp (section, ".gdb-tdesc") == 0)
-- 
2.25.1

Re: [PATCH] [aarch64] sme: Core file support

[Nick Clifton]

Hi Luis, Hi Ezra,

> Add required code to support core file dumps with NT_ARM_ZA and NT_ARM_SSVE
> register sets in them.
> 
> These new register sets are dumped when SME is supported.

Approved - please apply.

Cheers
   Nick

Re: [PATCH] [aarch64] sme: Core file support

[Luis Machado]

On 7/7/23 09:45, Nick Clifton wrote:
> Hi Luis, Hi Ezra,
> 
>> Add required code to support core file dumps with NT_ARM_ZA and NT_ARM_SSVE
>> register sets in them.
>>
>> These new register sets are dumped when SME is supported.
> 
> Approved - please apply.
> 
> Cheers
>   Nick
> 
> 

Thanks Nick. I'll push this once the gdb-side changes are in place.

Re: [PATCH] [aarch64] sme: Core file support

[Luis Machado]

On 7/7/23 09:45, Nick Clifton wrote:
> Hi Luis, Hi Ezra,
> 
>> Add required code to support core file dumps with NT_ARM_ZA and NT_ARM_SSVE
>> register sets in them.
>>
>> These new register sets are dumped when SME is supported.
> 
> Approved - please apply.
> 
> Cheers
>   Nick
> 
> 

Pushed now.