public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH] libopcodes/s390: add support for disassembler styling
Date: Thu, 7 Jul 2022 11:53:34 +0100	[thread overview]
Message-ID: <5870a0d3-3d7a-a1b2-96c7-a387a895bb7a@redhat.com> (raw)
In-Reply-To: <20220707102509.1267936-1-aburgess@redhat.com>

Hi Andrew,

> This commit adds disassembler style to the libopcodes s390
> disassembler.

Don't you also need to set "info->created_styled_output = true;"
in opcodes/disassemble.c:disassemble_init_for_target() ?

Cheers
   Nick


  reply	other threads:[~2022-07-07 10:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 10:25 Andrew Burgess
2022-07-07 10:53 ` Nick Clifton [this message]
2022-07-08 10:20   ` Andrew Burgess
2022-07-08 10:43     ` Nick Clifton
2022-07-08 12:18       ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5870a0d3-3d7a-a1b2-96c7-a387a895bb7a@redhat.com \
    --to=nickc@redhat.com \
    --cc=aburgess@redhat.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).