public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] gprofng: test suite problems
Date: Wed, 27 Apr 2022 20:22:12 -0700	[thread overview]
Message-ID: <5c3177d7-3f46-c4fe-92ca-4f7dc13e1f4d@oracle.com> (raw)
In-Reply-To: <87ilqukr3b.fsf@esperi.org.uk>



On 4/27/22 17:07, Nick Alcock wrote:
> On 27 Apr 2022, Vladimir Mezentsev via Binutils verbalised:
>
>> From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>>
>> gprofng/ChangeLog
>> 2022-04-27  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>
>>
>> 	PR gprofng/29065
>> 	* testsuite/lib/Makefile.skel: set LD_LIBRARY_PATH
> This seems like a misleading description to me.  LD_LIBRARY_PATH was
> already being set: you're just changing *how* it's set.
>
> Perhaps
>
>> 	* testsuite/lib/Makefile.skel: Search parent dir for libs too.

Nick, thanks for review.
I will change gprofng/ChangeLog.

> (assuming that's actually what it's doing? "root" is a rather odd
> directory name, and I say that even though I quite possibly wrote this
> code.)
  yes. You wrote this code.

-Vladimir



  reply	other threads:[~2022-04-28  3:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27  9:36 vladimir.mezentsev
2022-04-28  0:07 ` Nick Alcock
2022-04-28  3:22   ` Vladimir Mezentsev [this message]
2022-05-25  9:08 ` Luis Machado
2022-05-25 17:19   ` Vladimir Mezentsev
2022-05-26  7:26     ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c3177d7-3f46-c4fe-92ca-4f7dc13e1f4d@oracle.com \
    --to=vladimir.mezentsev@oracle.com \
    --cc=binutils@sourceware.org \
    --cc=nick.alcock@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).