Re: [PATCH] gprofng: test suite problems

[Luis Machado <luis.machado@arm.com>]

On 5/25/22 18:19, Vladimir Mezentsev wrote:
> 
> 
> On 5/25/22 02:08, Luis Machado wrote:
>> Hi,
>>
>> Just wondering, how long is the gprofng testsuite run suppose to take?
> 
>   There are ~15 gprofng tests. Each test runs ~ 1 minute (does not depend on the machine).
> 
> 
> 
>>
>> It seems to take a long time to execute (aarch64-linux Ubuntu 22.04), to the
>> point where it makes validation of other components a bit annoying. I clocked it at 7m 53s, on a reasonably
>> powerful machine.
>>
>> Ideally one would "make check" everything, but with this particular suite taking
>> so long, it is tempting to skip it.
>>
>> Does it parallelize based on -j input?
> 
> If you run only gprofng tests :  `(cd BLD_DIR/gprofng; make check -j ... ) `,  it doesn't parallelize.
> If you run all binutils tests: `(cd BLD_DIR/; make check -j ... ) `, each testsuite runs in parallel.

I see.

Trying a "make check-gprofng -j$(nproc)" with 64 cores still gives me the same 7 minutes or so for the testsuite run.

A single-process "make check-gprofng" gives me around 8 minutes. It doesn't look that much different.


>>
>> On 4/27/22 10:36, Vladimir Mezentsev via Binutils wrote:
>>> From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>>>
>>> gprofng/ChangeLog
>>> 2022-04-27  Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>>>
>>>     PR gprofng/29065
>>>     * testsuite/lib/Makefile.skel: set LD_LIBRARY_PATH
>>> ---
>>>   gprofng/testsuite/lib/Makefile.skel | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/gprofng/testsuite/lib/Makefile.skel b/gprofng/testsuite/lib/Makefile.skel
>>> index 7134c2715b5..7810ba7ed7a 100644
>>> --- a/gprofng/testsuite/lib/Makefile.skel
>>> +++ b/gprofng/testsuite/lib/Makefile.skel
>>> @@ -39,8 +39,8 @@ DISPLAY        = $(GPROFNG) display text
>>>   EXPERIMENT  = test.er
>>>   DISPLAY_LOG = display.log
>>>   -
>>> -export LD_LIBRARY_PATH := $(shell dirname $$(find ../root -name libgprofng.so.0 | head -1))
>>> +gprofng_dir := $(shell dirname $$(find ../root -name libgprofng.so.0 | head -1))
>>> +export LD_LIBRARY_PATH := $(gprofng_dir):$(gprofng_dir)/..
>>>     .PHONY: all collect compare clobber clean
>>
>