* [PATCH v3] ld: write resolved path to included file to dependency-file
@ 2023-09-18 19:42 Thomas Weißschuh
2023-09-21 6:03 ` Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Weißschuh @ 2023-09-18 19:42 UTC (permalink / raw)
To: binutils; +Cc: Thomas Weißschuh, Jan Beulich, Alan Modra
In ldfile_open_command_file_1() name written to the dependency files is
the name as specified passed to the "INCLUDE" directive.
This is before include-path processing so the tracked dependency
location is most likely wrong.
Instead track the opened file at the point where the resolved path is
actually available, in try_open().
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
---
v2: https://sourceware.org/pipermail/binutils/2023-September/129503.html
v2 -> v3:
* drop "write absolute paths to dependencies"
* fix code style in conditional
v1: https://sourceware.org/pipermail/binutils/2023-September/129475.html
v1 -> v2:
* push call to track_dependencies() into try_open() to catch all
dependencies
* sign-off commits
* write absolute paths to dependencies
ld/ldfile.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/ld/ldfile.c b/ld/ldfile.c
index b8fd4e5d8e0a..d73e251402c8 100644
--- a/ld/ldfile.c
+++ b/ld/ldfile.c
@@ -529,7 +529,10 @@ try_open (const char *name, bool *sysrooted)
result = fopen (name, "r");
if (result != NULL)
- *sysrooted = is_sysrooted_pathname (name);
+ {
+ *sysrooted = is_sysrooted_pathname (name);
+ track_dependency_files (name);
+ }
if (verbose)
{
@@ -711,8 +714,6 @@ ldfile_open_command_file_1 (const char *name, enum script_open_style open_how)
return;
}
- track_dependency_files (name);
-
lex_push_file (ldlex_input_stack, name, sysrooted);
lineno = 1;
base-commit: 95ebc6fdec5780bf59685739cdd55cd41d0f55ac
--
2.42.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3] ld: write resolved path to included file to dependency-file
2023-09-18 19:42 [PATCH v3] ld: write resolved path to included file to dependency-file Thomas Weißschuh
@ 2023-09-21 6:03 ` Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2023-09-21 6:03 UTC (permalink / raw)
To: Thomas Weißschuh; +Cc: Alan Modra, binutils
On 18.09.2023 21:42, Thomas Weißschuh wrote:
> In ldfile_open_command_file_1() name written to the dependency files is
> the name as specified passed to the "INCLUDE" directive.
> This is before include-path processing so the tracked dependency
> location is most likely wrong.
>
> Instead track the opened file at the point where the resolved path is
> actually available, in try_open().
>
> Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
Thanks, committed.
Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-21 6:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-18 19:42 [PATCH v3] ld: write resolved path to included file to dependency-file Thomas Weißschuh
2023-09-21 6:03 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).