From: Jan Beulich <jbeulich@suse.com>
To: WANG Xuerui <i.swmail@xen0n.name>
Cc: Chenghua Xu <xuchenghua@loongson.cn>,
Zhensong Liu <liuzhensong@loongson.cn>,
Qinggang Meng <mengqinggang@loongson.cn>,
Xi Ruoyao <xry111@xry111.site>, WANG Xuerui <git@xen0n.name>,
binutils@sourceware.org
Subject: Re: [PATCH RESEND] elfedit: add support for editing e_flags
Date: Thu, 2 Mar 2023 10:02:51 +0100 [thread overview]
Message-ID: <6376e192-2b15-354c-e051-269245f3efc5@suse.com> (raw)
In-Reply-To: <bd90e127-22c3-e566-2007-01c17a5ef4cc@suse.com>
On 02.03.2023 09:58, Jan Beulich via Binutils wrote:
> On 02.03.2023 09:14, WANG Xuerui wrote:
>> + tmp = strtoul (optarg, &end, 0);
>> + if (*end != '\0' || tmp > 0xffffffff)
>
> I'm afraid this may trigger compiler warnings: For one because the constant
> isn't flagged as unsigned. And then (for 32-bit targets) for being an
> always-true comparison.
Argh, always-false (but you get the point).
Jan
prev parent reply other threads:[~2023-03-02 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 8:14 WANG Xuerui
2023-03-02 8:58 ` Jan Beulich
2023-03-02 9:02 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6376e192-2b15-354c-e051-269245f3efc5@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=git@xen0n.name \
--cc=i.swmail@xen0n.name \
--cc=liuzhensong@loongson.cn \
--cc=mengqinggang@loongson.cn \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).