Re: [binutils-gdb] Add --enable-linker-version option to bfd linker to add an entry in the .comment section.

Re: [binutils-gdb] Add --enable-linker-version option to bfd linker to add an entry in the .comment section.

[Andreas Schwab]

On Mär 15 2023, Nick Clifton via Binutils-cvs wrote:

> +Inserts a string containing the version of the linker at the current
> +point.  Note - by default this directive is disabled and will do
> +nothing.  It only becomes active if the
> +@option{--enable-linker-version} command line option is used.

That does not say what it describes.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: [binutils-gdb] Add --enable-linker-version option to bfd linker to add an entry in the .comment section.

[Nick Clifton]

Hi Andreas,

>> +Inserts a string containing the version of the linker at the current
>> +point.  Note - by default this directive is disabled and will do
>> +nothing.  It only becomes active if the
>> +@option{--enable-linker-version} command line option is used.
> 
> That does not say what it describes.

Do you mean that it does not document the format of the string that
is inserted by the LINKER_VERSION script command ?

Would this addition be sufficient for you ?

   "The inserted string is the same as would be shown on the
    first line of the output from linker if it were to be run
    with the --version option specified"

Cheers
   Nick

Re: [binutils-gdb] Add --enable-linker-version option to bfd linker to add an entry in the .comment section.

[Andreas Schwab]

On Okt 17 2023, Nick Clifton wrote:

> Hi Andreas,
>
>>> +Inserts a string containing the version of the linker at the current
>>> +point.  Note - by default this directive is disabled and will do
>>> +nothing.  It only becomes active if the
>>> +@option{--enable-linker-version} command line option is used.
>> That does not say what it describes.
>
> Do you mean that it does not document the format of the string that
> is inserted by the LINKER_VERSION script command ?

It does not mention LINKER_VERSION at all, so that the paragraph does
not make any sense.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: [binutils-gdb] Add --enable-linker-version option to bfd linker to add an entry in the .comment section.

[Nick Clifton]

Hi Andreas,

>>>> +Inserts a string containing the version of the linker at the current
>>>> +point.  Note - by default this directive is disabled and will do

>>> That does not say what it describes.
>>
>> Do you mean that it does not document the format of the string that
>> is inserted by the LINKER_VERSION script command ?
> 
> It does not mention LINKER_VERSION at all, so that the paragraph does
> not make any sense.

Ah, now I understand.  I was confused because I thought that the @kindex
and @cindex directives before that paragraph would actually add text to
the ouput.

I am applying the patch below to fix this.

Cheers
   Nick

diff --git a/ld/ld.texi b/ld/ld.texi
index 2663f07e9ae..600c9d62806 100644
--- a/ld/ld.texi
+++ b/ld/ld.texi
@@ -5516,10 +5516,10 @@ expression.

  @kindex LINKER_VERSION
  @cindex LINKER_VERSION
-Inserts a string containing the version of the linker at the current
-point.  Note - by default this directive is disabled and will do
-nothing.  It only becomes active if the
-@option{--enable-linker-version} command line option is used.
+The @code{LINKER_VERSION} command inserts a string containing the
+version of the linker at the current point.  Note - by default this
+directive is disabled and will do nothing.  It only becomes active if
+the @option{--enable-linker-version} command line option is used.

  Built-in linker scripts for ELF based targets already include this
  directive in their @samp{.comment} section.