* [PATCH] loongarch: Don't check ABI flags if no code section
@ 2022-04-28 17:25 Xi Ruoyao
2022-05-05 11:04 ` liuzhensong
0 siblings, 1 reply; 2+ messages in thread
From: Xi Ruoyao @ 2022-04-28 17:25 UTC (permalink / raw)
To: binutils; +Cc: Wu Xiaotian, Wang Xuerui, Xi Ruoyao, Chenghua Xu, Zhensong Liu
Various packages (glib and gtk4 for example) produces data-only objects
using `ld -r -b binary` or `objcopy`, with no elf header flags set. But
these files also have no code sections, so they should be compatible
with all ABIs.
bfd/
* elfnn-loongarch.c (elfNN_loongarch_merge_private_bfd_data):
Skip ABI checks if the input has no code sections.
Reported-by: Wu Xiaotian <yetist@gmail.com>
Suggested-by: Wang Xuerui <i@xen0n.name>
Signed-off-by: Xi Ruoyao <xry111@mengyan1223.wang>
---
bfd/elfnn-loongarch.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
index 3c7268c02b8..307757f5dd5 100644
--- a/bfd/elfnn-loongarch.c
+++ b/bfd/elfnn-loongarch.c
@@ -389,6 +389,27 @@ elfNN_loongarch_merge_private_bfd_data (bfd *ibfd, struct bfd_link_info *info)
if (!_bfd_elf_merge_object_attributes (ibfd, info))
return false;
+ /* If the input BFD is not a dynamic object and it does not contain any
+ non-data sections, do not account its ABI. For example, various
+ packages produces such data-only relocatable objects with
+ `ld -r -b binary` or `objcopy`, and these objects have zero e_flags.
+ But they are compatible with all ABIs. */
+ if (!(ibfd->flags & DYNAMIC))
+ {
+ asection *sec;
+ bool have_code_sections = false;
+ for (sec = ibfd->sections; sec != NULL; sec = sec->next)
+ if ((bfd_section_flags (sec)
+ & (SEC_LOAD | SEC_CODE | SEC_HAS_CONTENTS))
+ == (SEC_LOAD | SEC_CODE | SEC_HAS_CONTENTS))
+ {
+ have_code_sections = true;
+ break;
+ }
+ if (!have_code_sections)
+ return true;
+ }
+
if (!elf_flags_init (obfd))
{
elf_flags_init (obfd) = true;
--
2.36.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] loongarch: Don't check ABI flags if no code section
2022-04-28 17:25 [PATCH] loongarch: Don't check ABI flags if no code section Xi Ruoyao
@ 2022-05-05 11:04 ` liuzhensong
0 siblings, 0 replies; 2+ messages in thread
From: liuzhensong @ 2022-05-05 11:04 UTC (permalink / raw)
To: Xi Ruoyao; +Cc: binutils, Wu Xiaotian, Wang Xuerui, Chenghua Xu
On 2022/4/29 上午1:25, Xi Ruoyao wrote:
> Various packages (glib and gtk4 for example) produces data-only objects
> using `ld -r -b binary` or `objcopy`, with no elf header flags set. But
> these files also have no code sections, so they should be compatible
> with all ABIs.
>
> bfd/
> * elfnn-loongarch.c (elfNN_loongarch_merge_private_bfd_data):
> Skip ABI checks if the input has no code sections.
>
> Reported-by: Wu Xiaotian <yetist@gmail.com>
> Suggested-by: Wang Xuerui <i@xen0n.name>
> Signed-off-by: Xi Ruoyao <xry111@mengyan1223.wang>
> ---
> bfd/elfnn-loongarch.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
> index 3c7268c02b8..307757f5dd5 100644
> --- a/bfd/elfnn-loongarch.c
> +++ b/bfd/elfnn-loongarch.c
> @@ -389,6 +389,27 @@ elfNN_loongarch_merge_private_bfd_data (bfd *ibfd, struct bfd_link_info *info)
> if (!_bfd_elf_merge_object_attributes (ibfd, info))
> return false;
>
> + /* If the input BFD is not a dynamic object and it does not contain any
> + non-data sections, do not account its ABI. For example, various
> + packages produces such data-only relocatable objects with
> + `ld -r -b binary` or `objcopy`, and these objects have zero e_flags.
> + But they are compatible with all ABIs. */
> + if (!(ibfd->flags & DYNAMIC))
> + {
> + asection *sec;
> + bool have_code_sections = false;
> + for (sec = ibfd->sections; sec != NULL; sec = sec->next)
> + if ((bfd_section_flags (sec)
> + & (SEC_LOAD | SEC_CODE | SEC_HAS_CONTENTS))
> + == (SEC_LOAD | SEC_CODE | SEC_HAS_CONTENTS))
> + {
> + have_code_sections = true;
> + break;
> + }
> + if (!have_code_sections)
> + return true;
> + }
> +
> if (!elf_flags_init (obfd))
> {
> elf_flags_init (obfd) = true;
已合入
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=83c5f3aea9a0d55be73e6d5dedd653fc32f0d6d3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-05 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-28 17:25 [PATCH] loongarch: Don't check ABI flags if no code section Xi Ruoyao
2022-05-05 11:04 ` liuzhensong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).