public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Nick Clifton <nickc@redhat.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] gas: accept custom ".linefile <n> ."
Date: Mon, 14 Nov 2022 16:53:15 +0100	[thread overview]
Message-ID: <67e11650-f96f-81c8-7901-98dd47b5e577@suse.com> (raw)
In-Reply-To: <8587d119-b296-57b5-d99f-d30f3ec7c846@redhat.com>

On 14.11.2022 14:43, Nick Clifton wrote:
>> While .linefile is generally intended for gas internal use only, its use
>> in a source file would better not result in an internal error.
> 
> Agreed.
> 
>> Give use
>> of it outside of any macro(-like) construct the meaning of restoring the
>> original (physical) input file name.
> 
> We should document this behaviour in the as.texi file then, so that it
> is "official"...

Do you really think we should? .linefile as a whole is undocumented. If
people use it, then at their own risk (if we made things "official",
later we couldn't later behavior anymore). The point of the change here
was merely to avoid an internal error that I had noticed. The particular
behavior chosen was simply the one easiest to implement (and at least
halfway sensible) while addressing the issue.

I am, btw, doing further work in this area, which includes zapping
.linefile from listings (where I think it should never have appeared,
but I didn't think of that aspect several months ago). Such zapping
would imo also be unreasonable if the directive became "official".

Jan

  reply	other threads:[~2022-11-14 15:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11  7:32 Jan Beulich
2022-11-14 13:43 ` Nick Clifton
2022-11-14 15:53   ` Jan Beulich [this message]
2022-11-14 16:02     ` Nick Clifton
2022-11-14 16:16       ` Jan Beulich
2022-11-15 11:16         ` Nick Clifton
2022-11-15  7:59   ` Jan Beulich
2022-11-15 11:23     ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67e11650-f96f-81c8-7901-98dd47b5e577@suse.com \
    --to=jbeulich@suse.com \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).