From: Jan Beulich <jbeulich@suse.com>
To: Nick Clifton <nickc@redhat.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] gas: accept custom ".linefile <n> ."
Date: Tue, 15 Nov 2022 08:59:01 +0100 [thread overview]
Message-ID: <77dc27ff-3293-4073-29e2-b9ee1a00016a@suse.com> (raw)
In-Reply-To: <8587d119-b296-57b5-d99f-d30f3ec7c846@redhat.com>
On 14.11.2022 14:43, Nick Clifton wrote:
>> --- a/gas/input-scrub.c
>> +++ b/gas/input-scrub.c
>> @@ -469,13 +469,15 @@ new_logical_line_flags (const char *fnam
>> /* FIXME: we could check that include nesting is correct. */
>> break;
>> case 1 << 3:
>> - if (line_number < 0 || fname != NULL || next_saved_file == NULL)
>> + if (line_number < 0 || fname != NULL)
>> abort ();
>
> I still hate having calls to abort() in code. Much better to have
> a helpful error message IMHO. Not important for this patch though.
So do you consider gas_assert() better? I've been using abort() (here
and elsewhere) only because of pre-existing adjacent uses and H.J. at
some point (in x86 code) asking me to use that in favor of gas_assert().
Personally I'd prefer making things like the above assertions. But
perhaps such could also be as_fatal().
Jan
next prev parent reply other threads:[~2022-11-15 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 7:32 Jan Beulich
2022-11-14 13:43 ` Nick Clifton
2022-11-14 15:53 ` Jan Beulich
2022-11-14 16:02 ` Nick Clifton
2022-11-14 16:16 ` Jan Beulich
2022-11-15 11:16 ` Nick Clifton
2022-11-15 7:59 ` Jan Beulich [this message]
2022-11-15 11:23 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77dc27ff-3293-4073-29e2-b9ee1a00016a@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).