[PATCH 0/1] RISC-V: Handle 'Zca' extension on ".option arch"

[PATCH 0/1] RISC-V: Handle 'Zca' extension on ".option arch"

[Tsukasa OI]

Hi,

While I'm testing the PATCH v2 of the 'Zihintntl', I found a bug in GAS.

(Normally I wouldn't attach a cover letter for the patch set that simple,
I felt it's needed for a little context; PATCH v2 of 'Zihintntl' will need
this bug fix.)

While the 'Zca' extension is the new base for compressed instructions,
it was not correctly handled in the ".option arch" handling.  This patch
set fixes this issue.  After grepping "c", I think it's the last code to
test.

Thanks,
Tsukasa




Tsukasa OI (1):
  RISC-V: Enable RVC on ".option arch, +zca" etc.

 gas/config/tc-riscv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


base-commit: 3dfee72010248aca5932a27b4c34d3b79ab9f057
-- 
2.41.0

[PATCH 1/1] RISC-V: Enable RVC on ".option arch, +zca" etc.

[Tsukasa OI]

From: Tsukasa OI <research_trasio@irq.a4lg.com>

Since the 'Zca' extension is the new base of the compressed instructions,
this commit enables RVC *also* when the 'Zca' extension is enabled
via ".option arch" directive.

gas/ChangeLog:

	* config/tc-riscv.c (s_riscv_option): Enable RVC also when the
	'Zca' extension is enabled after an ".option arch" directive.
---
 gas/config/tc-riscv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c
index 80c14a3cd221..aaf8b9be64fd 100644
--- a/gas/config/tc-riscv.c
+++ b/gas/config/tc-riscv.c
@@ -4376,7 +4376,8 @@ s_riscv_option (int x ATTRIBUTE_UNUSED)
       riscv_reset_subsets_list_arch_str ();
 
       riscv_set_rvc (false);
-      if (riscv_subset_supports (&riscv_rps_as, "c"))
+      if (riscv_subset_supports (&riscv_rps_as, "c")
+	  || riscv_subset_supports (&riscv_rps_as, "zca"))
 	riscv_set_rvc (true);
 
       if (riscv_subset_supports (&riscv_rps_as, "ztso"))
-- 
2.41.0

Re: [PATCH 0/1] RISC-V: Handle 'Zca' extension on ".option arch"

[Nelson Chu]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

Thanks, I did forget this, it looks good.

Nelson

On Tue, Jul 25, 2023 at 9:56 AM Tsukasa OI <research_trasio@irq.a4lg.com>
wrote:

> Hi,
>
> While I'm testing the PATCH v2 of the 'Zihintntl', I found a bug in GAS.
>
> (Normally I wouldn't attach a cover letter for the patch set that simple,
> I felt it's needed for a little context; PATCH v2 of 'Zihintntl' will need
> this bug fix.)
>
> While the 'Zca' extension is the new base for compressed instructions,
> it was not correctly handled in the ".option arch" handling.  This patch
> set fixes this issue.  After grepping "c", I think it's the last code to
> test.
>
> Thanks,
> Tsukasa
>
>
>
>
> Tsukasa OI (1):
>   RISC-V: Enable RVC on ".option arch, +zca" etc.
>
>  gas/config/tc-riscv.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
>
> base-commit: 3dfee72010248aca5932a27b4c34d3b79ab9f057
> --
> 2.41.0
>
>

Re: [PATCH 0/1] RISC-V: Handle 'Zca' extension on ".option arch"

[Tsukasa OI]

On 2023/07/25 11:21, Nelson Chu wrote:
> Thanks, I did forget this, it looks good.
> 
> Nelson

Thanks, committing.

Best,
Tsukasa

> 
> On Tue, Jul 25, 2023 at 9:56 AM Tsukasa OI <research_trasio@irq.a4lg.com
> <mailto:research_trasio@irq.a4lg.com>> wrote:
> 
>     Hi,
> 
>     While I'm testing the PATCH v2 of the 'Zihintntl', I found a bug in GAS.
> 
>     (Normally I wouldn't attach a cover letter for the patch set that
>     simple,
>     I felt it's needed for a little context; PATCH v2 of 'Zihintntl'
>     will need
>     this bug fix.)
> 
>     While the 'Zca' extension is the new base for compressed instructions,
>     it was not correctly handled in the ".option arch" handling.  This patch
>     set fixes this issue.  After grepping "c", I think it's the last code to
>     test.
> 
>     Thanks,
>     Tsukasa
> 
> 
> 
> 
>     Tsukasa OI (1):
>       RISC-V: Enable RVC on ".option arch, +zca" etc.
> 
>      gas/config/tc-riscv.c | 3 ++-
>      1 file changed, 2 insertions(+), 1 deletion(-)
> 
> 
>     base-commit: 3dfee72010248aca5932a27b4c34d3b79ab9f057
>     -- 
>     2.41.0
>