From: Jan Beulich <jbeulich@suse.com>
To: "Cui,Lili" <lili.cui@intel.com>
Cc: binutils@sourceware.org, hjl.tools@gmail.com
Subject: Re: [PATCH] Correct cpu_flags for CPU_ANY_AVX512BW_FLAGS
Date: Thu, 23 Jun 2022 09:29:36 +0200 [thread overview]
Message-ID: <6cdbbd05-3305-9595-4aca-e547347c80da@suse.com> (raw)
In-Reply-To: <20220623071404.15863-1-lili.cui@intel.com>
On 23.06.2022 09:14, Cui,Lili wrote:
> This patch is to correct cpu_flags for CPU_ANY_AVX512BW_FLAGS.
> Make check-gas is ok.
> Ok for master?
>
> Thanks,
> Lili.
>
> Change it from "CPU_ANY_AVX512_FP16_FLAGS" to "CpuAVX512_FP16"
You don't say what's wrong with what there is right now. I for one
think what we have is correct: If one disables BW, _all_ its
dependents should be disabled as well, which transitively means all
dependents of FP16.
Jan
> opcodes/
>
> * i386-gen.c (cpu_flag_init): Change cpu_flags of
> CPU_ANY_AVX512BW_FLAGS.
> ---
> opcodes/i386-gen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/opcodes/i386-gen.c b/opcodes/i386-gen.c
> index d18a7d2754..5dc224efdb 100644
> --- a/opcodes/i386-gen.c
> +++ b/opcodes/i386-gen.c
> @@ -382,7 +382,7 @@ static initializer cpu_flag_init[] =
> { "CPU_ANY_AVX512DQ_FLAGS",
> "CpuAVX512DQ" },
> { "CPU_ANY_AVX512BW_FLAGS",
> - "CpuAVX512BW|CPU_ANY_AVX512_FP16_FLAGS" },
> + "CpuAVX512BW|CpuAVX512_FP16" },
> { "CPU_ANY_AVX512VL_FLAGS",
> "CpuAVX512VL" },
> { "CPU_ANY_AVX512IFMA_FLAGS",
next prev parent reply other threads:[~2022-06-23 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 7:14 Cui,Lili
2022-06-23 7:29 ` Jan Beulich [this message]
2022-06-23 8:08 ` Cui, Lili
2022-06-23 16:04 ` H.J. Lu
2022-06-23 16:07 ` Jan Beulich
2022-06-23 16:31 ` H.J. Lu
2022-06-24 1:56 ` H.J. Lu
2022-06-24 2:03 ` Cui, Lili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cdbbd05-3305-9595-4aca-e547347c80da@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=lili.cui@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).