From: Nick Clifton <nickc@redhat.com>
To: Martin Storsjo <martin@martin.st>, binutils@sourceware.org
Subject: Re: [PATCH v3 1/2] ld: Add support for a new option, -exclude-symbols, in COFF object file directives
Date: Mon, 1 Aug 2022 12:11:33 +0100 [thread overview]
Message-ID: <6dbbfb87-203c-9b38-a854-6b53fce223a9@redhat.com> (raw)
In-Reply-To: <20220728133737.4049560-1-martin@martin.st>
Hi Martin,
> This maps to the same as ld's --exclude-symbols command line option,
> but allowing specifying the option via directives embedded in the
> object files instead of passed manually on the command line.
> ---
> v2: Fixed parsing multiple comma separated symbols. While pe_dll_add_excludes
> does tokenize the string, the symbol tokens in deffilep.y don't
> include commas, so we need to handle that at that level.
>
> v3: Added an x86_64 testcase too, changed i*86 into i?86 in the testcases.
Patch approved - please apply.
Cheers
Nick
next prev parent reply other threads:[~2022-08-01 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 13:37 Martin Storsjo
2022-07-28 13:37 ` [PATCH v3 2/2] ld: Support the -exclude-symbols option via COFF def files, with the EXCLUDE_SYMBOLS keyword Martin Storsjo
2022-08-01 11:12 ` Nick Clifton
2022-08-01 20:24 ` Martin Storsjö
2022-08-01 11:11 ` Nick Clifton [this message]
2022-08-01 11:35 ` [PATCH v3 1/2] ld: Add support for a new option, -exclude-symbols, in COFF object file directives Martin Storsjö
2022-08-01 12:25 ` Nick Clifton
2022-08-01 13:18 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dbbfb87-203c-9b38-a854-6b53fce223a9@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=martin@martin.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).