public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Andreas Schwab <schwab@suse.de>, Palmer Dabbelt <palmer@dabbelt.com>
Cc: binutils@sourceware.org, nelson@rivosinc.com
Subject: Re: [PATCH] RISC-V: Protect .got with relro
Date: Wed, 27 Sep 2023 15:55:49 -0600	[thread overview]
Message-ID: <739f4c3c-9fd4-4bf8-b9c7-77e6c156cd7b@gmail.com> (raw)
In-Reply-To: <mvmo7hqshy8.fsf@suse.de>



On 9/25/23 03:47, Andreas Schwab via Binutils wrote:
> On Sep 25 2023, Palmer Dabbelt wrote:
> 
>> I think we also want something like this
>>
>> diff --git a/ld/testsuite/ld-elf/binutils.exp b/ld/testsuite/ld-elf/binutils.exp
>> index 674e8e9a575..b38e29ed6fb 100644
>> --- a/ld/testsuite/ld-elf/binutils.exp
>> +++ b/ld/testsuite/ld-elf/binutils.exp
>> @@ -95,7 +95,6 @@ proc binutils_test { prog_name ld_options test {test_name ""} {readelf_options "
>> 			      || [istarget "mips*-*-*"] \
>> 			      || [istarget "nios2*-*-*"] \
>> 			      || [istarget "or1k-*-*"] \
>> -			      || [istarget "riscv*-*-*"] \
>> 			      || [istarget "sh*-*-*"] \
>> 			      || [istarget "x86_64-*-rdos*"])]
>> 	# Check if GNU_RELRO segment is generated.
> 
> Thanks, I will squash that in.
Thanks for taking care of the RELRO stuff.  One of the many items that 
could have easily slipped through the cracks.

jeff

      parent reply	other threads:[~2023-09-27 21:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25  8:19 Andreas Schwab
2023-09-25  9:26 ` Palmer Dabbelt
2023-09-25  9:47   ` Andreas Schwab
2023-09-25  9:53     ` Palmer Dabbelt
2023-09-27 21:55     ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=739f4c3c-9fd4-4bf8-b9c7-77e6c156cd7b@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=nelson@rivosinc.com \
    --cc=palmer@dabbelt.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).