From: Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>
To: Alan Modra <amodra@gmail.com>
Cc: <binutils@sourceware.org>, <christophe.lyon@arm.com>,
Yvan ROUX <yvan.roux@foss.st.com>
Subject: Re: [PATCH v2] bfd: Discard region regardless of warning flag
Date: Tue, 20 Dec 2022 11:38:55 +0100 [thread overview]
Message-ID: <742a0e75-55c6-9449-68e7-d151bb3c1bea@foss.st.com> (raw)
In-Reply-To: <Y6Ds46Mt7Bo5UK6x@squeak.grove.modra.org>
On 2022-12-19 23:59, Alan Modra wrote:
> On Mon, Dec 19, 2022 at 07:34:51PM +0100, Torbjörn SVENSSON via Binutils wrote:
>> v1 -> v2:
>> Added testcase
>>
>> Ok for trunk?
>
> This is OK except for a few minor things.
>
>> I have commit access for GDB. Do I still need someone to push this for
>> me or do I automatically have write access to the complete binutils
>> repository and just need the approval to push it myself?
>
> You should be able to push it.
>
>> The discard of the region should be performed regardless if the warning
>
> This should say "The discard of symbols in..." not "The discard of...".
> The code here is handling symbols.
>
>> for the discard is enabled or not.
>
>> +++ b/ld/testsuite/ld-arm/non-contiguous-arm7.d
>> @@ -0,0 +1,4 @@
>> +#name: non-contiguous-arm7
>> +#source: non-contiguous-arm7.s
>> +#ld: --enable-non-contiguous-regions -T non-contiguous-arm7.ld --gc-sections
>
> Please remove --gc-sections. The testcase doesn't need it.
>
Pushed with the modifications mentioned above.
prev parent reply other threads:[~2022-12-20 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 18:34 Torbjörn SVENSSON
2022-12-19 22:59 ` Alan Modra
2022-12-20 10:38 ` Torbjorn SVENSSON [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=742a0e75-55c6-9449-68e7-d151bb3c1bea@foss.st.com \
--to=torbjorn.svensson@foss.st.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=christophe.lyon@arm.com \
--cc=yvan.roux@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).