From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH 2/2] x86: break gas dependency on libopcodes
Date: Thu, 17 Nov 2022 17:59:50 +0100 [thread overview]
Message-ID: <7593a96c-6895-9636-22ef-0a18bd5e5d1b@suse.com> (raw)
In-Reply-To: <CAMe9rOoA5VN=ZWYazeX7Xz5kwJ2-+uDS0AY=24kVD57jnd3QiA@mail.gmail.com>
On 17.11.2022 17:55, H.J. Lu wrote:
> On Thu, Nov 17, 2022 at 8:53 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 17.11.2022 17:48, H.J. Lu wrote:
>>> On Thu, Nov 17, 2022 at 5:29 AM Jan Beulich <jbeulich@suse.com> wrote:
>>>> --- a/gas/configure.ac
>>>> +++ b/gas/configure.ac
>>>> @@ -420,7 +420,7 @@ changequote([,])dnl
>>>>
>>>> # Do we need the opcodes library?
>>>> case ${cpu_type} in
>>>> - vax | tic30)
>>>> + vax | tic30 | i386)
>>>> ;;
>>>
>>> This change isn't needed to move i386_seg_prefixes to gas.
>>
>> Correct, but it is needed to fulfill the purpose of the patch as per
>> its title. Otherwise an unused NEEDED entry remains in gas'es .dynamic.
>
> This patch should be a standalone patch.
I'll split, but I'm nevertheless curious as to why: With it in a separate
patch, there'll be an intermediate bogus state - gas will require
libopcodes.so for no reason. Personally I'd consider such a (minor) bug.
Jan
next prev parent reply other threads:[~2022-11-17 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 13:27 [PATCH 0/2] " Jan Beulich
2022-11-17 13:29 ` [PATCH 1/2] x86: instantiate i386_{op,reg}tab[] in gas instead of in libopcodes Jan Beulich
2022-11-17 13:29 ` [PATCH 2/2] x86: break gas dependency on libopcodes Jan Beulich
2022-11-17 16:48 ` H.J. Lu
2022-11-17 16:53 ` Jan Beulich
2022-11-17 16:55 ` H.J. Lu
2022-11-17 16:59 ` Jan Beulich [this message]
2022-11-17 17:01 ` H.J. Lu
2022-11-17 17:07 ` H.J. Lu
2022-11-18 6:53 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7593a96c-6895-9636-22ef-0a18bd5e5d1b@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).