Re: [PATCH 2/2] x86: break gas dependency on libopcodes

[Jan Beulich <jbeulich@suse.com>]

On 17.11.2022 18:01, H.J. Lu wrote:
> On Thu, Nov 17, 2022 at 8:59 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 17.11.2022 17:55, H.J. Lu wrote:
>>> On Thu, Nov 17, 2022 at 8:53 AM Jan Beulich <jbeulich@suse.com> wrote:
>>>>
>>>> On 17.11.2022 17:48, H.J. Lu wrote:
>>>>> On Thu, Nov 17, 2022 at 5:29 AM Jan Beulich <jbeulich@suse.com> wrote:
>>>>>> --- a/gas/configure.ac
>>>>>> +++ b/gas/configure.ac
>>>>>> @@ -420,7 +420,7 @@ changequote([,])dnl
>>>>>>
>>>>>>      # Do we need the opcodes library?
>>>>>>      case ${cpu_type} in
>>>>>> -      vax | tic30)
>>>>>> +      vax | tic30 | i386)
>>>>>>         ;;
>>>>>
>>>>> This change isn't needed to move i386_seg_prefixes to gas.
>>>>
>>>> Correct, but it is needed to fulfill the purpose of the patch as per
>>>> its title. Otherwise an unused NEEDED entry remains in gas'es .dynamic.
>>>
>>> This patch should be a standalone patch.
>>
>> I'll split, but I'm nevertheless curious as to why: With it in a separate
> 
> It should be the first patch, not the last.

Of course it cannot be the last one; in my v2 series it would have been
patch 2, but now you've already committed a patch to do that move. You
don't, however, answer my question, because from my pov the configure
change now ought to become part of patch 1 (i.e. again the one removing
the last dependency). As said - I'll submit the updated series, but I
would _still_ like to have an answer to the "Why?" question. Not the
least also going forward, in case a somewhat similar change would turn
up again.

Jan