From: Nick Clifton <nickc@redhat.com>
To: Waqar Hameed <whame91@gmail.com>, binutils@sourceware.org
Subject: Re: [PATCH] objdump: Round ASCII art lines in jump visualization
Date: Tue, 18 Jul 2023 16:24:27 +0100 [thread overview]
Message-ID: <75e3c5a2-2098-90e6-13b0-4a007adcc58b@redhat.com> (raw)
In-Reply-To: <878rbrgzoz.fsf@gmail.com>
Hi Waqar,
> Lines with rounded corners are easier to follow (and easier on the
> eyes). Use `,` and `'` instead of `/` and `\`, respectively, when
> drawing lines for jumps.
Well this is kind of a personal thing, and not everyone may agree with
your choice of characters. So how about allowing the user to select the
characters that they like ? For example if you added a new command line
option:
--visualize-jump-chars="/,+>'"
which could then be used to provide the characters displayed at various
points on the graph. Obviously this would be a more complicated patch,
and would require adding some more documentation, but overall I think that
it would be worthwhile...
Cheers
Nick
next prev parent reply other threads:[~2023-07-18 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 21:47 Waqar Hameed
2023-07-18 15:24 ` Nick Clifton [this message]
2023-07-18 17:21 ` Waqar Hameed
2023-07-19 10:18 ` Nick Clifton
2024-04-23 15:11 ` Nick Clifton
2024-04-23 17:09 ` Waqar Hameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75e3c5a2-2098-90e6-13b0-4a007adcc58b@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=whame91@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).