From: "Martin Storsjö" <martin@martin.st>
To: Mark Harmstone <mark@harmstone.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v4 1/2] ld: Add --pdb option
Date: Tue, 11 Oct 2022 22:06:11 +0300 (EEST) [thread overview]
Message-ID: <766dd6bf-15a-2399-ebf0-4c8ab92b4bf@martin.st> (raw)
In-Reply-To: <20221011175332.17156-1-mark@harmstone.com>
On Tue, 11 Oct 2022, Mark Harmstone wrote:
> Resubmission incorporating Martin's amendment
> (https://sourceware.org/pipermail/binutils/2022-October/123481.html)
>
> ---
> bfd/libpei.h | 6 +++--
> bfd/peXXigen.c | 30 ++++++++++++++++-----
> bfd/peicode.h | 2 +-
> ld/emultempl/pe.em | 50 +++++++++++++++++++++++++++++++----
> ld/emultempl/pep.em | 48 +++++++++++++++++++++++++++++++---
> ld/testsuite/ld-pe/pdb.exp | 53 ++++++++++++++++++++++++++++++++++++++
> ld/testsuite/ld-pe/pdb1.s | 5 ++++
> 7 files changed, 175 insertions(+), 19 deletions(-)
> create mode 100644 ld/testsuite/ld-pe/pdb.exp
> create mode 100644 ld/testsuite/ld-pe/pdb1.s
Thanks! This version LGTM wrt the public option interface.
// Martin
prev parent reply other threads:[~2022-10-11 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 17:53 Mark Harmstone
2022-10-11 17:53 ` [PATCH v4 2/2] ld: Add minimal pdb generation Mark Harmstone
2022-10-12 0:28 ` Alan Modra
2022-10-12 0:31 ` Mark Harmstone
2022-10-11 19:06 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=766dd6bf-15a-2399-ebf0-4c8ab92b4bf@martin.st \
--to=martin@martin.st \
--cc=binutils@sourceware.org \
--cc=mark@harmstone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).