From: Nick Clifton <nickc@redhat.com>
To: Ulf Samuelsson <binutils@emagii.com>, binutils@sourceware.org
Subject: Re: [RFC v0 0/1] Add support for CRC64 generation in linker
Date: Fri, 17 Feb 2023 10:55:50 +0000 [thread overview]
Message-ID: <77d80241-860c-2cdb-cf82-cd41ec89e2dc@redhat.com> (raw)
In-Reply-To: <1a9ce7de-4006-9ebc-7012-5e11c42a7559@emagii.com>
Hi Ulf,
> Before CRC:
> 0x00001100: 0xefbeadde45444f43 0x0000000000000000 0x0000000000000000 0x0000000000001118
>
> *CRC [0xc79d3a1ef51fb737] update at 0x00001110 succeeded*
>
> After CRC:
> 0x00001100: 0xefbeadde45444f43 0x0000000000000000 0xc79d3a1ef51fb737 0x0000000000001118
Sorry - I am a little confused here. Does this mean that your v0
patch set is working ? I was going to suggest that the reason that
calling bfd_get_section_contents() does not work, is that it is being
called too early - before the contents have actually been assigned.
I am also concerned that your patch includes copyrighted code that
appears to come without any license attached. (Maybe it is in the
LICENSE file that you say you could not upload ?)
Also - from a flexibility point of view - wouldn't it be better if
the CRC were to be computed by an external program, rather than being
built into the linker ? That way the user could decide exactly which
digest algorithm they wanted to use. I am pretty sure that you can
arrange for the patch to fork/exec another program to compute the
CRC for you.
Cheers
Nick
next prev parent reply other threads:[~2023-02-17 10:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 20:40 binutils
2023-02-16 20:40 ` [PATCH v0 1/6] CRC64 header binutils
2023-02-16 20:40 ` [PATCH v0 2/6] ldlang.h: CRC64 binutils
2023-02-16 20:40 ` [PATCH v0 3/6] ldlex.l: CRC64 binutils
2023-02-16 20:40 ` [PATCH v0 4/6] ldgram.y: CRC64 binutils
2023-02-16 20:40 ` [PATCH v0 5/6] ldlang.c: CRC64 binutils
2023-02-16 20:40 ` [PATCH v0 6/6] ldlang.c: Try to get the .text section for checking CRC binutils
2023-02-16 21:30 ` [RFC v0 0/1] Add support for CRC64 generation in linker Fangrui Song
[not found] ` <DS7PR12MB57657A0E46493FAAA203AF77CBA09@DS7PR12MB5765.namprd12.prod.outlook.com>
2023-02-16 22:37 ` Ulf Samuelsson
2023-02-17 11:11 ` Nick Clifton
2023-02-17 12:03 ` Ulf Samuelsson
2023-03-06 7:50 ` Fangrui Song
[not found] ` <DS7PR12MB57654E11983392D5DCBF1D85CBB69@DS7PR12MB5765.namprd12.prod.outlook.com>
2023-03-06 10:00 ` Ulf Samuelsson
2023-02-17 7:53 ` Ulf Samuelsson
2023-02-17 10:55 ` Nick Clifton [this message]
[not found] ` <DS7PR12MB5765096101240054A648F8C9CBA09@DS7PR12MB5765.namprd12.prod.outlook.com>
2023-02-17 10:46 ` Nick Clifton
-- strict thread matches above, loose matches on Subject: below --
2023-02-16 13:19 binutils
2023-02-16 13:21 ` Ulf Samuelsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77d80241-860c-2cdb-cf82-cd41ec89e2dc@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@emagii.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).