From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] i386: Check invalid (%dx) usage
Date: Mon, 7 Nov 2022 10:55:27 +0100 [thread overview]
Message-ID: <781ed098-079c-212e-7e46-a375c27f5486@suse.com> (raw)
In-Reply-To: <20221104205547.3728827-1-hjl.tools@gmail.com>
On 04.11.2022 21:55, H.J. Lu via Binutils wrote:
> (%dx) isn't a valid memory address in any modes. It is used as a special
> memory operand for input/output port address in AT&T syntax and should
> only be used with input/output instructions. Update i386_att_operand to
> set i.input_output_operand to true for (%dx) and issue an error if (%dx)
> is used with non-input/output instructions.
Hmm, this shouldn't require a new flag I would hope. We did properly reject
bad uses up to 2.31 ("operand type mismatch"). Whatever was broken there
would need correcting instead, imo. A possible candidate looks to be
2fb5be8dac9d ("x86: drop {,reg16_}inoutportreg variables"), albeit perhaps
combined with later changes - in 2.33 behavior changed again.
Jan
next prev parent reply other threads:[~2022-11-07 9:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 20:55 H.J. Lu
2022-11-07 9:55 ` Jan Beulich [this message]
2022-11-07 11:44 ` Jan Beulich
2022-11-07 19:58 ` H.J. Lu
2022-11-08 7:34 ` Jan Beulich
2022-11-08 21:06 ` H.J. Lu
2022-11-09 7:21 ` Jan Beulich
2022-11-09 20:24 ` H.J. Lu
2022-11-10 7:21 ` Jan Beulich
2022-11-10 17:22 ` H.J. Lu
2022-11-11 7:55 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=781ed098-079c-212e-7e46-a375c27f5486@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).