Re: [PATCHv3] libopcodes: extend the styling within the i386 disassembler

[Andrew Burgess <aburgess@redhat.com>]

Jan Beulich via Binutils <binutils@sourceware.org> writes:

> On 27.05.2022 19:44, Andrew Burgess via Binutils wrote:
>> @@ -11595,11 +11750,15 @@ OP_E_memory (instr_info *ins, int bytemode, int sizeflag)
>>  	      print_displacement (ins, ins->scratchbuf, disp);
>>  	    else
>>  	      print_operand_value (ins, ins->scratchbuf, 1, disp);
>> -	    oappend (ins, ins->scratchbuf);
>> +	    oappend_with_style (ins, ins->scratchbuf,
>> +				dis_style_address_offset);
>
> Is there a reason you changed this to dis_style_address_offset, but
> not the other cases where print_displacement() is used (always for
> similar purposes)? I'm asking because I'm going to touch all these
> instances, so if dis_style_address_offset was always meant to be
> used there, I'd switch that around kind of as a side effect.

I think they should all be dis_style_address_offset.  Sorry for missing
these.

Thanks,
Andrew