From: Nick Alcock <nick.alcock@oracle.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Indu Bhagat <indu.bhagat@oracle.com>,
binutils@sourceware.org, i@maskray.me
Subject: Re: [PATCH] libctf: remove unnecessary zstd constructs
Date: Tue, 13 Dec 2022 13:20:23 +0000 [thread overview]
Message-ID: <878rjbfnjc.fsf@esperi.org.uk> (raw)
In-Reply-To: <Y5WH1owfmqPIztMh@vapier> (Mike Frysinger's message of "Sun, 11 Dec 2022 16:33:42 +0900")
On 11 Dec 2022, Mike Frysinger verbalised:
> On 10 Dec 2022 16:26, Indu Bhagat wrote:
>> This patch is essentially a revert of
>> commit-id: 8818c80cbd4116ef5af171ec47c61167179e225c
>> (libctf: Add ZSTD_LIBS to LIBS so that ac_cv_libctf_bfd_elf can be true)
>>
>> As the specific configure check now uses libtool, this explicit mention of the
>> dependency $ZSTD_LIBS is not needed anymore.
>>
>> As for AC_ZSTD, it was suggested to clean it up (https://sourceware.org/pipermail/binutils/2022-December/125026.html)
>> as it is unused. Althought this patch does remove AC_ZSTD from
>> libctf/configure.ac, I am not completely sure anymore: libctf may have
>> plans to support zstd compressed CTF sections soon/later ?
>
> if libctf ever gains such support, it's easy enough to add back in.
Yeah, that's part of the v4 plans, and adding this back would be a tiny
part of that. (And pulling this out seems harmless for now in any case
-- it was only there to see if bfd would need it to successfully link,
and that is no longer needed with the bfd configure check using
libtool.)
--
NULL && (void)
next prev parent reply other threads:[~2022-12-13 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 0:26 Indu Bhagat
2022-12-11 7:33 ` Mike Frysinger
2022-12-12 6:44 ` Fangrui Song
[not found] ` <DS7PR12MB5765BBA01B80D4CAB3C51C9DCBE29@DS7PR12MB5765.namprd12.prod.outlook.com>
2022-12-12 9:47 ` Mike Frysinger
2022-12-13 13:20 ` Nick Alcock [this message]
2022-12-12 16:00 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rjbfnjc.fsf@esperi.org.uk \
--to=nick.alcock@oracle.com \
--cc=binutils@sourceware.org \
--cc=i@maskray.me \
--cc=indu.bhagat@oracle.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).