public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>, binutils@sourceware.org
Subject: [PUSHED] Enable styling for GDB (Was: [PATCH] opcodes: style m68k disassembler output)
Date: Sat, 25 Feb 2023 10:23:53 +0000	[thread overview]
Message-ID: <87ilfqjb5y.fsf@redhat.com> (raw)
In-Reply-To: <877cwere3q.fsf@igel.home>


Andreas,

Thanks for adding styling for m68k.

I pushed the patch below as obvious; this enables use of your new
styling within GDB.  Hope this is OK.

Thanks,
Andrew

---

commit 82341e9798202fa94b801b1428a8bf68dc80149a
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Sat Feb 25 10:16:34 2023 +0000

    opcodes/m68k: enable libopcodes styling for GDB
    
    The following commit added libopcodes styling for m68k:
    
      commit c22ff449275c91e4842bb10c650e83c572580f65
      Date:   Tue Feb 14 18:07:19 2023 +0100
    
          opcodes: style m68k disassembler output
    
    but didn't set disassemble_info::created_styled_output in
    disassemble.c, which is needed in order for GDB to start using the
    libopcodes based styling.
    
    This commit fixes this small oversight.  GDB now styles correctly.

diff --git a/opcodes/disassemble.c b/opcodes/disassemble.c
index ff8cb87f599..93052e75088 100644
--- a/opcodes/disassemble.c
+++ b/opcodes/disassemble.c
@@ -652,6 +652,11 @@ disassemble_init_for_target (struct disassemble_info * info)
       info->skip_zeroes = 32;
       break;
 #endif
+#ifdef ARCH_m68k
+    case bfd_arch_m68k:
+      info->created_styled_output = true;
+      break;
+#endif
 #ifdef ARCH_mep
     case bfd_arch_mep:
       info->skip_zeroes = 256;


  parent reply	other threads:[~2023-02-25 10:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-18 19:02 [PATCH] opcodes: style m68k disassembler output Andreas Schwab
2023-02-20 12:55 ` Nick Clifton
2023-02-25 10:23 ` Andrew Burgess [this message]
2023-02-25 10:33   ` [PUSHED] Enable styling for GDB Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilfqjb5y.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).