public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [Committed] RISC-V: Report "c or zca" for INSN_CLASS_C when error reporting.
@ 2023-08-18  4:07 Nelson Chu
  2023-08-18  6:57 ` Andreas Schwab
  0 siblings, 1 reply; 2+ messages in thread
From: Nelson Chu @ 2023-08-18  4:07 UTC (permalink / raw)
  To: binutils; +Cc: nelson.rivosinc.com, Nelson Chu

bfd/
	* elfxx-riscv.c (riscv_multi_subset_supports_ext): Return "c or zca"
	rather than "c".
---
 bfd/elfxx-riscv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
index e9852ef8fa1..cb65024beaf 100644
--- a/bfd/elfxx-riscv.c
+++ b/bfd/elfxx-riscv.c
@@ -2625,7 +2625,7 @@ riscv_multi_subset_supports_ext (riscv_parse_subset_t *rps,
     case INSN_CLASS_Q:
       return "q";
     case INSN_CLASS_C:
-      return "c";
+      return _("c' or `zca");
     case INSN_CLASS_F_AND_C:
       if (!riscv_subset_supports (rps, "f"))
 	{
-- 
2.39.2 (Apple Git-143)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Committed] RISC-V: Report "c or zca" for INSN_CLASS_C when error reporting.
  2023-08-18  4:07 [Committed] RISC-V: Report "c or zca" for INSN_CLASS_C when error reporting Nelson Chu
@ 2023-08-18  6:57 ` Andreas Schwab
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Schwab @ 2023-08-18  6:57 UTC (permalink / raw)
  To: Nelson Chu; +Cc: binutils, nelson.rivosinc.com

On Aug 18 2023, Nelson Chu wrote:

> diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
> index e9852ef8fa1..cb65024beaf 100644
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -2625,7 +2625,7 @@ riscv_multi_subset_supports_ext (riscv_parse_subset_t *rps,
>      case INSN_CLASS_Q:
>        return "q";
>      case INSN_CLASS_C:
> -      return "c";
> +      return _("c' or `zca");

That text is substituted into a longer sentence, and not i18n friendly.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-18  6:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-18  4:07 [Committed] RISC-V: Report "c or zca" for INSN_CLASS_C when error reporting Nelson Chu
2023-08-18  6:57 ` Andreas Schwab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).