From: Andrew Burgess <aburgess@redhat.com>
To: Nelson Chu <nelson.chu@sifive.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH 0/3] disassembler syntax highlighting in objdump (via libopcodes)
Date: Thu, 17 Feb 2022 16:17:00 +0000 [thread overview]
Message-ID: <87ley9eadf.fsf@redhat.com> (raw)
In-Reply-To: <CAJYME4HD-85A7c9yyPqvoMsR=Et8+dc-bSVcDNpcn7xvP9NY_Q@mail.gmail.com>
Nelson Chu <nelson.chu@sifive.com> writes:
> Hi Andrew,
>
> I get gas/testsuite/gas/riscv/insn testcase fail after applying the
> series of patches. Here is the reduced case,
>
> $ cat tmp.s
> .word 0x68c58543
> fmadd.s fa0,fa1,fa2,fa3,rne
> .insn r MADD, 0, 0, a0, a1, a2, a3
> .insn 0x68c58543
>
> All these are the same instruction encoding - fmadd.s, but the first
> ".word" will be marked and dumped as data rather than instruction. We
> are used to get the following dump result,
>
> $ /scratch/nelsonc/build-upstream/rv64gc-elf/build-install/bin/riscv64-unknown-elf-objdump
> -d tmp.o
>
> 0000000000000000 <.text>:
> 0: 68c58543 .word 0x68c58543
> 4: 68c58543 fmadd.s fa0,fa1,fa2,fa3,rne
> 8: 68c58543 fmadd.s fa0,fa1,fa2,fa3,rne
> c: 68c58543 fmadd.s fa0,fa1,fa2,fa3,rne
>
> But now with the patches, I will get segmentation fault when trying to
> dump fmadd.s as instruction,
>
> $ /scratch/nelsonc/build-upstream/rv64gc-elf/build-install/bin/riscv64-unknown-elf-objdump
> -d tmp.o
>
> 0000000000000000 <.text>:
> 0: 68c58543 .word 0x68c58543
> Segmentation fault (core dumped)
>
> Is it possible if you could help to see what happened? Thanks!
Sorry about that. I'll get this fixed and post an updated version.
Thanks,
Andrew
next prev parent reply other threads:[~2022-02-17 16:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 20:53 Andrew Burgess
2022-02-16 20:53 ` [PATCH 1/3] objdump/opcodes: add syntax highlighting to disassembler output Andrew Burgess
2022-02-28 15:54 ` Tom Tromey
2022-02-16 20:53 ` [PATCH 2/3] opcodes/riscv: implement style support in the disassembler Andrew Burgess
2022-02-19 10:24 ` Andrew Burgess
2022-02-16 20:53 ` [PATCH 3/3] opcodes/i386: partially implement disassembler style support Andrew Burgess
2022-02-17 9:35 ` Jan Beulich
2022-02-17 16:15 ` Andrew Burgess
2022-02-17 16:29 ` Jan Beulich
2022-02-17 22:37 ` Andrew Burgess
2022-02-18 7:14 ` Jan Beulich
2022-02-19 10:54 ` Andrew Burgess
2022-02-21 13:08 ` Jan Beulich
2022-02-21 18:01 ` Andrew Burgess
2022-02-17 3:57 ` [PATCH 0/3] disassembler syntax highlighting in objdump (via libopcodes) Nelson Chu
2022-02-17 16:17 ` Andrew Burgess [this message]
2022-03-21 14:33 ` [PATCHv2 " Andrew Burgess
2022-03-21 14:33 ` [PATCHv2 1/3] objdump/opcodes: add syntax highlighting to disassembler output Andrew Burgess
2022-03-21 14:33 ` [PATCHv2 2/3] opcodes/riscv: implement style support in the disassembler Andrew Burgess
2022-03-21 14:33 ` [PATCHv2 3/3] opcodes/i386: partially implement disassembler style support Andrew Burgess
2022-03-24 17:08 ` [PATCHv2 0/3] disassembler syntax highlighting in objdump (via libopcodes) Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ley9eadf.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=binutils@sourceware.org \
--cc=nelson.chu@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).