From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: "Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] bpf: fix error conversion from long unsigned int to unsigned int [-Werror=overflow]
Date: Fri, 06 Jan 2023 14:56:32 +0100 [thread overview]
Message-ID: <87mt6vg41b.fsf@oracle.com> (raw)
In-Reply-To: <20230106075816.387489-1-guillermo.e.martinez@oracle.com> (Guillermo E. Martinez's message of "Fri, 6 Jan 2023 01:58:16 -0600")
Hi Guillermo.
> cpu/
> * bpf.cpu (define-call-insn): Remove `src' field from
> instruction mask.
I don't think this description accurately describes the real change?
You are basically adding an opcode for `src' to the instruction format.
> diff --git a/cpu/bpf.cpu b/cpu/bpf.cpu
> index 13dde7094c8..2ae74fc4c18 100644
> --- a/cpu/bpf.cpu
> +++ b/cpu/bpf.cpu
> @@ -768,7 +768,7 @@
> "call"
> (endian-isas x-endian)
> "call $disp32"
> - (+ disp32 (f-offset16 0) (f-regs 0)
> + (+ disp32 (f-offset16 0) (.sym src x-endian) ((.sym f-dst x-endian) 0)
> OP_CLASS_JMP OP_SRC_K OP_CODE_CALL)
> (c-call VOID
> "bpfbf_call" disp32 (ifield (.sym f-src x-endian)))
The BPF side of the patch is OK.
Thanks!
next prev parent reply other threads:[~2023-01-06 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 7:58 Guillermo E. Martinez
2023-01-06 10:39 ` Alan Modra
2023-01-06 15:15 ` Guillermo E. Martinez
2023-01-06 13:56 ` Jose E. Marchesi [this message]
2023-01-06 14:16 ` Jose E. Marchesi
2023-01-06 14:34 ` Guillermo E. Martinez
2023-01-07 15:47 ` Guillermo E. Martinez
2023-01-11 23:37 ` Guillermo E. Martinez
2023-01-11 23:54 ` Jose E. Marchesi
2023-01-12 2:50 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt6vg41b.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=binutils@sourceware.org \
--cc=guillermo.e.martinez@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).