From: Tom Tromey <tom@tromey.com>
To: Oleg Tolmatcev via Binutils <binutils@sourceware.org>
Cc: Oleg Tolmatcev <oleg.tolmatcev@gmail.com>
Subject: Re: [PATCH] add section caches to coff_data_type
Date: Thu, 04 May 2023 06:16:17 -0600 [thread overview]
Message-ID: <87o7n0thpq.fsf@tromey.com> (raw)
In-Reply-To: <CACcXsZjWfeQR3_pC3nVtq+sAkq-QGfEnA3DE2K8rsDnK9edWrQ@mail.gmail.com> (Oleg Tolmatcev via Binutils's message of "Sat, 29 Apr 2023 13:19:26 +0200")
>>>>> Oleg Tolmatcev via Binutils <binutils@sourceware.org> writes:
> Hello all,
> final patch to ld. All the patches together improve linking
> performance from 9 minutes to 1 minute when linking rpcs3 in debug
> mode with BUILD_LLVM=ON.
> + pe->coff.section_by_index
> + = htab_create (10, htab_hash_section_index, htab_eq_section_index, NULL);
> + pe->coff.section_by_target_index = htab_create (
> + 10, htab_hash_section_target_index, htab_eq_section_target_index, NULL);
I think something has to call htab_delete on these to avoid a memory leak.
Tom
prev parent reply other threads:[~2023-05-04 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 11:19 Oleg Tolmatcev
2023-05-04 11:29 ` Nick Clifton
2023-05-15 18:47 ` Oleg Tolmatcev
2023-05-16 13:27 ` Nick Clifton
2023-05-16 14:36 ` Oleg Tolmatcev
2023-05-04 12:16 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7n0thpq.fsf@tromey.com \
--to=tom@tromey.com \
--cc=binutils@sourceware.org \
--cc=oleg.tolmatcev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).