From: Nick Clifton <nickc@redhat.com>
To: Oleg Tolmatcev <oleg.tolmatcev@gmail.com>, binutils@sourceware.org
Subject: Re: [PATCH] add section caches to coff_data_type
Date: Thu, 4 May 2023 12:29:46 +0100 [thread overview]
Message-ID: <9cccec92-8a1d-445d-2d1d-16abcf870295@redhat.com> (raw)
In-Reply-To: <CACcXsZjWfeQR3_pC3nVtq+sAkq-QGfEnA3DE2K8rsDnK9edWrQ@mail.gmail.com>
Hi Oleg,
> final patch to ld. All the patches together improve linking
> performance from 9 minutes to 1 minute when linking rpcs3 in debug
> mode with BUILD_LLVM=ON.
Unfortunately there are two problems with this patch:
1. It does not initialise the new fields in the coff_tdata
structure for targets that just use the COFF file format
rather than the PE file format. (ie you need to duplicate
the patch to peicode.h in the coffcode.h file).
2. (Actually more important): We either need a copyright
assignment from you, or else you need to sign off on the
patch before we can accept it. To assign the copyright
you should fill out one of the forms here and then send
it off to the FSF:
https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=tree;f=doc/Copyright;h=22db9a802b4da96ad455cd933351c1359108f95d;hb=HEAD
Alternatively you can attach a developer's certificate of
origin to your patch, which is easier in the short term, but
does need to be done with every patch submission. More details
here:
https://sourceware.org/binutils/wiki/HowToContribute
Cheers
Nick
PS. For your other two patches, I decided to treat them as "obvious"
so no copyright assignment or DCO was needed.
next prev parent reply other threads:[~2023-05-04 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 11:19 Oleg Tolmatcev
2023-05-04 11:29 ` Nick Clifton [this message]
2023-05-15 18:47 ` Oleg Tolmatcev
2023-05-16 13:27 ` Nick Clifton
2023-05-16 14:36 ` Oleg Tolmatcev
2023-05-04 12:16 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cccec92-8a1d-445d-2d1d-16abcf870295@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=oleg.tolmatcev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).