From: Tom Tromey <tromey@adacore.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Tom Tromey <tromey@adacore.com>, binutils@sourceware.org
Subject: Re: [PATCH] Fix -Wmaybe-uninitialized warning in opcodes/i386-dis.c
Date: Fri, 21 Apr 2023 09:07:24 -0600 [thread overview]
Message-ID: <87pm7xz32r.fsf@tromey.com> (raw)
In-Reply-To: <703cf414-4714-fb3d-66bb-6acbb499e063@suse.com> (Jan Beulich's message of "Fri, 21 Apr 2023 15:24:09 +0200")
>>>>> "Jan" == Jan Beulich <jbeulich@suse.com> writes:
Jan> Would be nice if you could (also) state the compiler variant and
Jan> version, as that's generally more meaningful than a distro one.
I updated the commit message with this info.
>> This patch fixes the warning, but I don't know whether it's really
>> correct -- I just copied a pattern from eariler in this function.
Jan> It is correct, and it was my bad to not check the function's return
Jan> value. Please commit.
Thank you for the review. I'm checking it in.
Tom
prev parent reply other threads:[~2023-04-21 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 13:08 Tom Tromey
2023-04-21 13:24 ` Jan Beulich
2023-04-21 15:07 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm7xz32r.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).