From: Andrew Burgess <aburgess@redhat.com>
To: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH 1/3] objdump: fix extended (256) disassembler colors
Date: Wed, 10 Aug 2022 17:12:48 +0100 [thread overview]
Message-ID: <87sfm4yt4v.fsf@redhat.com> (raw)
In-Reply-To: <c43e26bc-cccc-4810-3144-d6c93c77cc31@redhat.com>
Nick Clifton via Binutils <binutils@sourceware.org> writes:
> Hi Andrew,
>
>> PR 29457
>> * objdump (objdump_styled_sprintf): Check disassembler_color
>> against an enum value, don't treat it as a bool.
>
> Doh - sorry for missing this. Patch approved - please apply.
I've pushed this patch. I'll rework #2 and #3 inline with your feedback
and repost.
Thanks,
Andrew
next prev parent reply other threads:[~2022-08-10 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 14:24 [PATCH 0/3] Disassembler styling, bug fixes and customisation Andrew Burgess
2022-08-10 14:24 ` [PATCH 1/3] objdump: fix extended (256) disassembler colors Andrew Burgess
2022-08-10 15:32 ` Nick Clifton
2022-08-10 16:12 ` Andrew Burgess [this message]
2022-08-10 14:24 ` [PATCH 2/3] objdump: introduce OBJDUMP_COLORS environment variable Andrew Burgess
2022-08-10 15:48 ` Nick Clifton
2022-08-10 14:24 ` [PATCH 3/3] objdump: allow the disassembler colors to be customized Andrew Burgess
2022-08-10 15:57 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfm4yt4v.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).